cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

fix: proposer deposit should be burned if proposal does not move into the deposit

Open p0mvn opened this issue 2 years ago • 2 comments

Summary of Bug

In https://github.com/cosmos/cosmos-sdk/pull/12771 we introduced a min proposer deposit at submission time.

The feature was ported from https://github.com/osmosis-labs/cosmos-sdk/pull/296

However, we later discovered that Osmosis sdk fork differs from this repository. Osmosis burns the deposit if it does not move into the voting period but this repository returns it.

Since #12771 was a direct backport, this important difference was left out.

We should be burning the proposer deposit from submission time so that it is an effective measure against spam resistance.

Version

main branch

Steps to Reproduce

  • submit the proposal and the initial deposit
  • do not fulfill the deposit requirement for moving into the voting period
  • observe that the deposit is returned (should be burned instead)

p0mvn avatar Aug 03 '22 18:08 p0mvn

I'm in favor of this 👍

alexanderbez avatar Aug 03 '22 20:08 alexanderbez

I started this a while ago but was waiting for the param migration., Need to resurrect this https://github.com/cosmos/cosmos-sdk/pull/11080. We will do it before the next release

ref https://github.com/cosmos/cosmos-sdk/issues/11057

tac0turtle avatar Aug 04 '22 07:08 tac0turtle

Can this be picked up? @marbar3778

atheeshp avatar Aug 16 '22 06:08 atheeshp

I guess this need to backport to 0.46?

yihuang avatar Aug 16 '22 07:08 yihuang

I guess this need to backport to 0.46?

This would be state breaking, no? If so, we cannot really backport to 0.46

alexanderbez avatar Aug 16 '22 20:08 alexanderbez

Can this be added to 0.47? The current spam situation is just getting worse in cosmos governance.

jhernandezb avatar Feb 22 '23 15:02 jhernandezb

Can this be added to 0.47? The current spam situation is just getting worse in cosmos governance.

v0.47 is feature frozen. However, this is included https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#minimum-proposal-deposit-at-time-of-submission and will probably solve that spam issue.

julienrbrt avatar Feb 22 '23 15:02 julienrbrt

I don't know why this was left out, if there is no penalty spam depositors will just get their money back even with a 20% min deposit.

jhernandezb avatar Feb 22 '23 15:02 jhernandezb

I don't know why this was left out, if there is no penalty spam depositors will just get their money back even with a 20% min deposit.

You are right!

julienrbrt avatar Feb 22 '23 15:02 julienrbrt

Superseded by https://github.com/cosmos/cosmos-sdk/issues/11057. #11057 will be included in v0.47 as per community request.

julienrbrt avatar Feb 23 '23 14:02 julienrbrt