cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

Make FormatTimeString and ParseTimeString methods

Open ValarDragon opened this issue 3 years ago • 3 comments

Summary

We should make string counterparts to FormatTimeBytes and ParseTimeBytes https://github.com/cosmos/cosmos-sdk/blob/eee23d95312ae41fa4fe4f6b218926685304590b/types/utils.go#L64-L77, and then make the bytes method call into those

For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

ValarDragon avatar Jul 20 '22 15:07 ValarDragon

can we make use of generics here?

tac0turtle avatar Jul 22 '22 12:07 tac0turtle

@ValarDragon would like to work on it , just to confirm we want to return string representation of time here ?

gopherine avatar Jul 28 '22 14:07 gopherine

For state serialization, we want bytes. See the APIs @ValarDragon pointed out in the issue body 👍

alexanderbez avatar Jul 29 '22 01:07 alexanderbez