chain-registry icon indicating copy to clipboard operation
chain-registry copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

PR 681 changes breaks some relayer commands

Open ashishchandr70 opened this issue 2 years ago • 3 comments

I was just playing with the relayer code in vscode and tried to execute command rly paths fetch with the chains set to cosmoshub and osmosis. However, it panics each time and I think that is because of PR #681

The IBCData struct still uses dashes for the key names in the json registry files.

See https://github.com/cosmos/relayer/blob/ffc46dc11b306b5673b7ca03ce5c4ee77ce4ce57/relayer/path.go#L105 for reference.

Here is the error. image

ashishchandr70 avatar Sep 08 '22 23:09 ashishchandr70

hi @ashishchandr70 , thanks for bringing this up.

For now, I believe reverting the change may resolve your issue, and likely not impact anything else built around the underscores, since it is a recent change. However, I believe the issue that called for that change has some validity. I'm wondering (and hoping) that a PR to update that struct at the same time can resolve this and prevent issues like this in the future...

JeremyParish69 avatar Sep 10 '22 03:09 JeremyParish69

@JeremyParish69 thanks for your response. Would the PR be created by someone on the relayer team? Should I close this issue or leave it open?

ashishchandr70 avatar Sep 13 '22 22:09 ashishchandr70

@JeremyParish69 thanks for your response. Would the PR be created by someone on the relayer team? Should I close this issue or leave it open?

I submitted a PR that has been merged. I might wait a couple days before closing to see if anyone (you?) can confirm that the issue is truly resolved.

JeremyParish69 avatar Sep 15 '22 00:09 JeremyParish69