surfrdf icon indicating copy to clipboard operation
surfrdf copied to clipboard

Py3

Open PonteIneptique opened this issue 6 years ago • 8 comments

So, I think I fixed #5 ...

PonteIneptique avatar Sep 11 '18 09:09 PonteIneptique

Let me know if this feel alright to you, so that I can clean a little...

PonteIneptique avatar Sep 11 '18 09:09 PonteIneptique

I would heavily recommend that this whole branch be squashed for a nicer history. I did not know where to put my name, so I did not put it anywhere... :)

PonteIneptique avatar Sep 11 '18 09:09 PonteIneptique

i'm a little confused about the imports from builtins. is that some layer provided by six?

funkyfuture avatar Sep 11 '18 15:09 funkyfuture

It comes from all the compatibility modules from future. Future brings future, past and some of builtins for python 2 I think.

PonteIneptique avatar Sep 11 '18 18:09 PonteIneptique

I actually started to move type(x) to isinstance but I figured you might not want it. Tell me and I'll revert the last two. As for the failure, it seems that there is sometime an issue with pytext upgrade because it works on my repo : https://travis-ci.org/PonteIneptique/surfrdf/jobs/427468789

PonteIneptique avatar Sep 12 '18 00:09 PonteIneptique

Hey, bumping this in case you can do something about it :)

PonteIneptique avatar Nov 02 '18 11:11 PonteIneptique

Just my usual bump, in case this was forgotten :) 👍

PonteIneptique avatar Jan 29 '19 19:01 PonteIneptique

@cosminbasca Hello. Just notice about intersting pull request.

maranqz avatar Apr 21 '20 20:04 maranqz