Renan Ribeiro
Renan Ribeiro
This doesn't seem to be a particular issue with `BlockingQueueSource` honestly. ```clj (defn foo [] (let [a (s/stream 4) b (s/batch 100 1 a)] (s/put-all! a [1 2 3 4])...
Can we consider this issue as closed? Or should we consider further adjusting mapcat?
Would it really be worth making deferreds implement `CompletionStage` instead of just providing something like `deferred->completable-future` by default?
Perhaps we could have a `CompletionStageDeferred` wrapper and calls to `d/->deferred` or `d/deferred` wrap the returned deferred into a `CompletionStageDeferred` that delegates the regular `IDeferred` calls to the original deferred,...
I've been playing with those potemkin macros in manifold, and they fit like a glove for `CompletionStage`. Is it be better to copy/adapt the source of those macros from potemkin,...
I'll take note on that, I have been playing with this, and CompletionStage is ok with implement with potemkin. However, testing the 30+ methods can be a bit overwhelming since...
The code I sent earlier is actually an adaptation for some of the JDK tests, they do basically the same assertions, only differences are the presence of tests for error...
Yep, the entire test file has the same coverage
Thanks for the feedback. I have implemented these changes mostly to reduce the amount of style warnings coming from the `checkStyleMain` build task in this file, however I can implement...
This makes sense. I'll be updating the PR in the following days to provide more meaningful changes (i.e documentation and final vars) to this and other classes in the `logisim.data`...