react-native-fabric icon indicating copy to clipboard operation
react-native-fabric copied to clipboard

0.5.2 is broken? (iOS)

Open TheRohitSharma opened this issue 7 years ago • 14 comments

I had to revert to 0.5.1 to get my build using React Native v0.55.4 to work with this module. I kept getting an error regarding Fabric being undefined when I attempted to use Fabric.Answers. Once I reverted to 0.5.1, it built just fine.

Not a big deal for me, but figured I'd give a heads up.

TheRohitSharma avatar Oct 01 '18 15:10 TheRohitSharma

can you share your error stacktrace?

does this happen on android as well?

cocoapods or react-native link?

sibelius avatar Oct 01 '18 15:10 sibelius

2018-10-01 10:44:11.068 [fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: Cannot read property 'Answers' of undefined 2018-10-01 10:44:11.090 [fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: Module AppRegistry is not a registered callable module (calling runApplication)

Haven't had time yet to test on Android. Using exact same code and settings that work without a problem using 0.5.1. Xcode version is 9.4.1.

Using react-native link

TheRohitSharma avatar Oct 01 '18 15:10 TheRohitSharma

react-native link react-native-fabric or just react-native link? it is safer to specify which lib you are trying to link sometimes react-native link can duplicate old links, if you are not passing which lib you want to link

jgcmarins avatar Oct 01 '18 15:10 jgcmarins

May not have unlinked before relinking. :/ Trying again.

TheRohitSharma avatar Oct 01 '18 16:10 TheRohitSharma

take a look at your settings.gradle file

jgcmarins avatar Oct 01 '18 16:10 jgcmarins

0.5.2 has an issue in iOS where the header paths specified in the SMXXCrashlytics.xcodeproj is not being set correectly. A fix has been merged into master, but a new version of the package has not been released on NPM yet. reverting back to 0.5.1 or using the master branch of this repo in your package.json file should work.

IndianAg0711 avatar Oct 02 '18 18:10 IndianAg0711

in which commit?

sibelius avatar Oct 02 '18 18:10 sibelius

@sibelius I'm looking through your commits and can't find anything recent that touched framework search paths directly - it was consistently setting a recursive search path that I had to change for the project to build correctly each time I installed 0.5.2, and when I attempted to use the master branch the search path was set correctly. Sorry I can't provide more info. Will try to dig deeper when I have time.

IndianAg0711 avatar Oct 04 '18 17:10 IndianAg0711

maybe releasing another release can fix this?

sibelius avatar Oct 04 '18 17:10 sibelius

possibly 🤞

IndianAg0711 avatar Oct 04 '18 19:10 IndianAg0711

I haven't had a chance to look either, but i did notice that running react-native link react-native-fabric on v0.5.2 just adds to my podfile instead of actually linking as it does <v0.5.2. This also causes issues because afterwards, pod install ends up installing React as well, at which point I have two copies of React which causes errors.

TheRohitSharma avatar Oct 05 '18 13:10 TheRohitSharma

Have the same exact problem with @TheRohitSharma

gedeagas avatar Nov 01 '18 16:11 gedeagas

I reproduce the problem on Android

bdelville avatar Nov 29 '18 04:11 bdelville

0.5.2 has an issue in iOS where the header paths specified in the SMXXCrashlytics.xcodeproj is not being set correectly. A fix has been merged into master, but a new version of the package has not been released on NPM yet. reverting back to 0.5.1 or using the master branch of this repo in your package.json file should work.

0.5.2 Works fine, but change the import to this : import * as FABRIC from 'react-native-fabric'

AND

FABRIC.Answers.logContentView('Home', 'Simple view', 'page-view');

Works.. 0/


import FABRIC from 'react-native-fabric' doesn't works for me in latest version (0.5.2)

diegorribeiro avatar Dec 11 '18 12:12 diegorribeiro