react-native-fabric icon indicating copy to clipboard operation
react-native-fabric copied to clipboard

Published 20 hours ago • verified publisher icon corymsmith

Fix logStartCheckout argument order on iOS

Open oblador opened this issue 8 years ago • 3 comments

The argument order in the ObjC implementation is out of sync with java and javascript. This PR fixes that, but is potentially breaking for existing installations using the wrong argument order (although I never got it to work that way either so I'm guessing no-one is using it).

oblador avatar Feb 01 '17 12:02 oblador

I am using it! @corymsmith could you check and merge this please?

fabriziomoscon avatar May 23 '17 11:05 fabriziomoscon

This change seems to be very critical.

ohtangza avatar Oct 10 '17 02:10 ohtangza

Perhaps we should merge this and just push a breaking change release? Library would be at 1.0.0, but is there any good reason for it not to be?

autoreleasefool avatar Apr 06 '18 15:04 autoreleasefool