Cory House comments

Results 67 comments of


                                            Cory House

Running development version very slow - any pointers as to why?

The easiest way is to fork the project. If you didn't do that, then it's a manual process. On Tue, May 1, 2018 at 2:26 AM, mstobin wrote: > What's...

Running development version very slow - any pointers as to why?

Wow, that's wild. I know reduxImmutableStateInvariant has a perf hit, which is why they say it should only be run in development, but I've never seen a perceivable impact on...

Add Redux Toolkit

Hi Mark - Thanks for the PR! I see good stuff in here I like such as the object form of mapDispatchToProps. You said this isn't ready for merge, so...

Create dev/index.html during development (using `npm start -s`)

If you need physical files, then why not just run the prod build: `npm run build`?

Create dev/index.html during development (using `npm start -s`)

Correct. No hot reloading on prod build. I'd recommend finding a way to run your React app all by itself so you can use `npm start`. (likely by hitting mock...

build script not failing the npm script

Thanks! I'd welcome a PR on these.

Adding docker support

Thanks for the PR! Dumb question: How would we update the Docker image hosted on hub.docker later?

Adding docker support

Great! I'm `housecor`

Adding docker support

I also don't know Docker well enough yet to vet this. I'm hoping to dive in soon for work but for now I'm no help on this.

Setup script fails to complete on windows

What command line are you using? On Sun, Jun 17, 2018 at 2:00 PM jshnaidman wrote: > *Describe the bug* > When I run npm run setup, it completes the...