corydickson

Results 27 issues of corydickson

Currently the decorator only verifies the spent voice credits for a single vote option. This fix would instead set a public variable to the ppt contract that has the total...

v1.0.0

- [ ] MACI.sol constructor should hash a value using the library and require it not to be zero - [ ] Track circomlib version number for deploys off chain

The circuit which process messages contains a duplicate check for the constraint, `enoughVoiceCredits` which is initially validated in the `messageValidator` circuit. Therefore this should be removed when processing each message...

enhancement
circuits

Related to #269, the `currentSbCommitment` could be skipped and manipulated by a malicious coordinator. This was originally addressed by ensuring in the circuit that the commitment start at zero prior...

enhancement

In order for the final state root to be correctly generated, all subtrees must be merged prior to calling `mergeStateAq`. Currently there is no check in place to ensure this...

bug
v1.0.0

A public function that has the signature ``` function verifyPerVOSpentVoiceCredits( uint8 _depth, uint256 _index, uint256 _leaf, uint256[][] memory _pathElements, uint256 _salt ) public view returns (bool) ```

enhancement
v1.0.0

Currently we rely on the circuit to generate correct results for the initial tally see #269. But in the future to avoid malicious contract calls and thus causing a revert,...

enhancement

Adjust the calculation of the initial index to include messages where the number of messages is larger and not divisible by the message batch size

bug
v1.0.0

MACI now needs a `PollFactory` to be initialized, including `MessageAqFactory`