osht icon indicating copy to clipboard operation
osht copied to clipboard

Fix JUnit XML output (fixes #5)

Open dcsobral opened this issue 6 years ago • 3 comments

Researching into this, I was able to confirm the current format is incorrect. In fact, I couldn't even see the results in the browser I used, until I applied the fix. Looking at one of the documented schemas I found, I could see the attributes being used corresponded to the testcase tag instead of the testcases tag, so I fixed it by introducing a new testcases tag and renaming the existing one.

dcsobral avatar Jul 01 '19 17:07 dcsobral

I vote for this fix

abourree avatar Jan 30 '20 15:01 abourree

That is very curious. The current osht behavior puts attributes in a tag that shouldn't have them -- I don't even understand how any system can read them. This PR doesn't split tests, it simply puts the summary in a single test suite. Each test is written as a separate test case as per current behavior -- nothing was changed there.

Perhaps the problem is that your internal system didn't recognize any test case at all before because of the invalid XML layout?

-- Daniel C. Sobral

On Tue, Mar 3, 2020 at 6:23 AM Michael Andrews [email protected] wrote:

I actually had an internal system reject my JUnit XML because this PR puts each test in a separate test suite. Maybe there should be an option for that instead of making it the default.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/coryb/osht/pull/8?email_source=notifications&email_token=AABCOF7DE25AAHYORZDWV7TRFUADHA5CNFSM4H4UKI42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENTOV7Q#issuecomment-593947390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCOF4IMVZZHOR7ZTHDZ63RFUADHANCNFSM4H4UKI4Q .

dcsobral avatar Jun 08 '20 20:06 dcsobral

I had the same issue in CircleCI. Pasting in the code from this PR fixed it.

garysieling avatar Nov 12 '20 21:11 garysieling