Nicola Corti
Nicola Corti
As I mentioned: > MissingPackageDeclaration just checks if there is a package declaration in your file or not. So this rule will essentially also flag all your files in the...
> If the rule was called NoFilesInRootPackage I'd get it right away and not enable it. So either we: - Add an alias to this rule as `NoFilesInRootPackage` - Check...
> So why not call it `NoFilesInRootPackage`? Leaves no room for confusion IMO. IMHO `MissingPackageDeclaration` it's clearer as it's straight to the point of what the failure is.
@paolorotolo are you able to do a pass on this one as well?
> I appreciate the credits but if we are going to merge my solution I rather work on it myself. Please open a PR then 🙏
cc @hezi which is taking care of our showcase
I was thinking about a different approach, but I'm unsure if is feasible: 1. Run Detekt once without Suppression. Save to a file similar to the baseline fine. 1. Have...
Yup that's correct. Are you up for sending a PR to fix it?
> Also, are the docs written as if the new architecture is the only choice? Or should old arch quirks still be mentioned until its removed? This specific doc should...
> Just wanted to mention it for the context, but leaving that for @cortinico or anyone else from the team to approve. @mattcarrollcode if we do have the Keynote youtube...