cortex icon indicating copy to clipboard operation
cortex copied to clipboard

Add storage "middleware" for OpenTracing and Instrumentation

Open tomwilkie opened this issue 7 years ago • 3 comments

The individual storage backends expose they're own, inconsistent metrics. I'm not suggesting these go away, as they have different retires policies etc, but a consistent wrapper for the Storage interface that adds instrumentation and tracing would also be useful.

tomwilkie avatar Feb 06 '18 15:02 tomwilkie

This is a good example of how we did it in the caching layer, and can be used here: https://github.com/cortexproject/cortex/blob/master/pkg/chunk/cache/instrumented.go and https://github.com/cortexproject/cortex/blob/master/pkg/ring/kv/metrics.go

We'd need it for these interfaces: https://github.com/cortexproject/cortex/blob/master/pkg/chunk/storage_client.go#L5-L28

gouthamve avatar Nov 11 '19 16:11 gouthamve

looking at this first

adnxn avatar Nov 12 '19 15:11 adnxn

I took off 'good first issue' because the 'chunks' code is now deprecated and the 'blocks' code comes from Thanos project, so any changes would have to be made there first.

bboreham avatar Jun 25 '21 10:06 bboreham

Distributed tracing is provided by opentelemetry now

friedrichg avatar Apr 24 '23 18:04 friedrichg