cortex icon indicating copy to clipboard operation
cortex copied to clipboard

Make NameValidationScheme configurable

Open yeya24 opened this issue 7 months ago • 9 comments

Is your feature request related to a problem? Please describe. Now NameValidationScheme is hardcoded to legacy. We want to allow users to enable UTF-8 validation mode behind a flag.

Describe the solution you'd like

Add a flag to turn on UTF-8 validation mode. Make sure to cover unit tests

yeya24 avatar Apr 16 '25 03:04 yeya24

Hi, @yeya24 can I help with it?

yumosx avatar Apr 16 '25 13:04 yumosx

@yumosx Yes please go ahead.

yeya24 avatar Apr 16 '25 16:04 yeya24

@yumosx Are you working on it? If not, can I try this one?

av153k avatar Apr 29 '25 06:04 av153k

I've been quite busy recently, you can try it.

yumosx avatar Apr 29 '25 07:04 yumosx

Okay. Thank you. @yumosx

av153k avatar Apr 29 '25 07:04 av153k

Hello @yeya24, This might be a bit silly to ask, but I wanted to confirm how the user would set that flag? By CMD variable, env variable or something else ??

av153k avatar Apr 29 '25 10:04 av153k

It will be both a flag and field in the config file.

yeya24 avatar May 02 '25 20:05 yeya24

Okay. Thank you.

av153k avatar May 04 '25 14:05 av153k

Hello @yeya24, I have created a draft PR for this commit. Adding tests is left. Just wanted to confirm by you, if I am on the right path in implementing the changes required by this issue. Once you confirm, I will add the tests and make the PR ready for review. I am sorry for doing this, I don't have much experience in OSS contribution, so.

av153k avatar May 08 '25 07:05 av153k

Hey @yeya24, if @av153k is not available, can I work on this? He’s done a great job, but since he mentioned he won’t be available, if the issue needs to be resolved quickly, I’m here to take it up. Thanks!

7h3-3mp7y-m4n avatar Jul 16 '25 22:07 7h3-3mp7y-m4n

I think this is resolved by https://github.com/cortexproject/cortex/pull/7040

yeya24 avatar Oct 15 '25 01:10 yeya24