cortex icon indicating copy to clipboard operation
cortex copied to clipboard
verified publisher icon cortexproject

Change all max async concurrency

Open SungJin1212 opened this issue 1 year ago • 2 comments

Change all max-async-concurrency default values 50 to 3 it includes -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency -blocks-storage.bucket-store.index-cache.redis.max-async-concurrency -blocks-storage.bucket-store.chunks-cache.memcached.max-async-concurrency -blocks-storage.bucket-store.chunks-cache.redis.max-async-concurrency

FYI. max-async-concurrency default values of the multilevels (index, chunks) are already 3.

Which issue(s) this PR fixes: Fixes #

Checklist

  • [ ] Tests updated
  • [x] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

SungJin1212 avatar Oct 15 '24 01:10 SungJin1212

Could you help me understand why the defaults are changed from 50 to 3?

harry671003 avatar Oct 15 '24 05:10 harry671003

@harry671003 50 goroutines taking a lot of CPUs as mentioned (comment) in #6249. And I got the comment to change all async concurrency in #6265.

SungJin1212 avatar Oct 15 '24 05:10 SungJin1212

@yeya24 Could you take review it ?

SungJin1212 avatar Oct 22 '24 11:10 SungJin1212