cortex icon indicating copy to clipboard operation
cortex copied to clipboard

Document runtime-config on https://cortexmetrics.io/docs/configuration/configuration-file/

Open alanprot opened this issue 2 years ago • 8 comments

The format of the runtime config is not documented anywhere on https://cortexmetrics.io/docs/configuration/configuration-file/

Even the per tenant limits (under overrides key) is not documented.

See: https://github.com/cortexproject/cortex/blob/74d33df75ecd4a138191f1a75ddd6f806f2c18b0/pkg/cortex/runtime_config.go#L24-L32

Some of the fields mention that it can be overridden but it's not clear how. Ex:

# The default tenant's shard size when the shuffle-sharding strategy is used.
# Must be set both on ingesters and distributors. When this setting is specified
# in the per-tenant overrides, a value of 0 disables shuffle sharding for the
# tenant.
# CLI flag: -distributor.ingestion-tenant-shard-size
[ingestion_tenant_shard_size: <int> | default = 0]

Ans some other fields we dont even have that reference. Ex: we can override by tenant the sse config but is not mentioned anywhere.

alanprot avatar Feb 16 '23 08:02 alanprot

Hello @alanprot, I would like to work on this issue.

Nitesh639 avatar Feb 16 '23 18:02 Nitesh639

Hi @Nitesh639! yeah.. please do.

Let me know if u need any guidance with it.

alanprot avatar Feb 16 '23 18:02 alanprot

@jeromeinsf Thank you for appointing me. I will try to resolve this issue asap. I have stuck to the college circular, so anyone who wants to work on this issue may go ahead.

Nitesh639 avatar Feb 24 '23 06:02 Nitesh639

Hey @Nitesh639 I can help you with that :)

ankur12-1610 avatar Feb 25 '23 07:02 ankur12-1610

Yes @ankur12-1610

Nitesh639 avatar Feb 26 '23 04:02 Nitesh639

@alanprot I'm working on on then :)

ankur12-1610 avatar Feb 26 '23 13:02 ankur12-1610

Related https://github.com/cortexproject/cortex/issues/3078

friedrichg avatar Mar 10 '23 02:03 friedrichg

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '23 09:06 stale[bot]