cortex icon indicating copy to clipboard operation
cortex copied to clipboard

add curl to support container probes with mTLS

Open danfromtitan opened this issue 4 years ago • 6 comments
trafficstars

What this PR does: Adds curl to the container image.

Which issue(s) this PR fixes: Fixes #4427

Checklist

  • [-] Tests updated
  • [-] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

danfromtitan avatar Nov 17 '21 18:11 danfromtitan

I prefer not to do this; see https://github.com/cortexproject/cortex/issues/4427#issuecomment-972707651

bboreham avatar Nov 18 '21 09:11 bboreham

I replied with more details in https://github.com/cortexproject/cortex/issues/4427#issuecomment-973058351 Until kubernetes adds support for client TLS http-get probes, I don't see any other option to probe Cortex containers with mTLS enabled.

danfromtitan avatar Dec 01 '21 02:12 danfromtitan

I replied with more details in #4427 (comment) Until kubernetes adds support for client TLS http-get probes, I don't see any other option to probe Cortex containers with mTLS enabled.

I concur. I don't think there is another way currently unfortunately since kubelet always skips cert validation when using https

nschad avatar Jan 19 '22 10:01 nschad

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 19 '22 12:04 stale[bot]

still needed

danfromtitan avatar Apr 19 '22 14:04 danfromtitan

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 22:07 stale[bot]