cortex icon indicating copy to clipboard operation
cortex copied to clipboard

Running Cortex on Kubernetes

Open charannaik opened this issue 3 years ago • 7 comments

image

The rolling update strategy with maxSurge, maxUnavailable does not apply to the statefulsets and hence not applicable to ingesters.

charannaik avatar Oct 21 '21 06:10 charannaik

Link for context: https://cortexmetrics.io/docs/guides/running-cortex-on-kubernetes/#take-extra-care-with-ingesters

We're running GEM on Kubernetes with the enterprise-metrics Helm chart: https://github.com/grafana/helm-charts/blob/main/charts/enterprise-metrics/templates/ingester-statefulset.yaml

adeverteuil avatar Oct 21 '21 15:10 adeverteuil

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 22 '22 14:01 stale[bot]

Reopening. Need clarification on the reported.

charannaik avatar Jan 31 '22 13:01 charannaik

This seems odd indeed. Maybe we should to replace that with the PDB documentation.

https://github.com/cortexproject/cortex-helm-chart/blob/master/templates/ingester/ingester-poddisruptionbudget.yaml

PRs are welcome! :D

alanprot avatar Jan 31 '22 17:01 alanprot

Maybe we should to replace that with the PDB documentation.

PDBs and update strategies apply to different cases. PDBs only apply in the context of node maintenance, like draining a node. The rollout policy applies to rolling out changes to the pod spec. For high availability, both policies must be in place. It makes sense for them to have corresponding policies, like each specifying maxUnavailable: 1.

kd7lxl avatar Feb 01 '22 19:02 kd7lxl

Reopening. Need clarification on the reported.

I just learned that the document in question was written assuming Deployment. That's why the doc talks about maxUnavailable and maxSurge for ingesters.

alvinlin123 avatar Feb 06 '22 06:02 alvinlin123

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 11:06 stale[bot]