cortex icon indicating copy to clipboard operation
cortex copied to clipboard

Feature Request: Allow limit overrides for a group of tenants

Open maxbrodin opened this issue 4 years ago • 8 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] Currently runtime configuration file only allows to override limits for individual tenant. It would be desirable to have the ability to override limits for a group of tenants allowing limit overrides to be applied to existing tenants as well as the new tenants within the same group.

Describe the solution you'd like Add regular expressions support in runtime_config overrides that will allow to set the same limit for a group of tenants that match the regular expression.

Describe alternatives you've considered An alternative would be a new "group of tenants" entity. But it seems that supporting Regex in runtime_config overrides is simpler and easier to implement.

maxbrodin avatar Feb 18 '21 00:02 maxbrodin

Add regular expressions support in runtime_config overrides that will allow to set the same limit for a group of tenants that match the regular expression.

I'm up to this. I think would be a great addition, as far as regular expression matching in the overrides can be conditionally enabled (otherwise would be a breaking change for users having regex-like tenant IDs).

pracucci avatar Feb 18 '21 08:02 pracucci

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 23 '21 18:05 stale[bot]

still_valid

jtlisi avatar May 24 '21 01:05 jtlisi

Currently the implementation is that the tenant ID in the overrides file is a string key into a map of overrides. If we add regex or similar, then we cannot just look up a tenant ID string in the map.

It might be best to have a separate section in the overrides for regex or group specifications, so there is no ambiguity and we can implement them differently.

bboreham avatar Jul 22 '21 15:07 bboreham

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 21 '21 03:10 stale[bot]

not stale

alvinlin123 avatar Oct 21 '21 03:10 alvinlin123

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 19 '22 05:01 stale[bot]

still want it.

alvinlin123 avatar Jan 19 '22 06:01 alvinlin123