cortex icon indicating copy to clipboard operation
cortex copied to clipboard

Ruler rules manager/querier should log trace ID's

Open cstyan opened this issue 3 years ago • 6 comments

Because rule evaluation for the ruler is started via the upstream Prometheus rules manager we don't have control over it's logging. The ruler passes a Querier to the rules manager as the Queryable.

The Querier starts it's own spans and logs trace IDs via spanlogger, but it's not immediately clear to me how we could have that trace ID logged when rule evaluation fails.

In order to debug things like rule evaluation failed in the Ruler with traces stored in some tracing backends, it would be very beneficial to have trace IDs logged.

cc @gotjosh @jtlisi

cstyan avatar Jul 31 '20 01:07 cstyan

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 07 '20 01:10 stale[bot]

bump

cstyan avatar Oct 08 '20 21:10 cstyan

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 08 '20 04:12 stale[bot]

Still valid.

gotjosh avatar Dec 08 '20 09:12 gotjosh

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 08 '21 16:03 stale[bot]

Still valid

pracucci avatar Mar 08 '21 17:03 pracucci