cortex-helm-chart icon indicating copy to clipboard operation
cortex-helm-chart copied to clipboard

Published 20 hours ago • verified publisher icon cortexproject

add nginx access log toggle

Open TuTuRyYE opened this issue 3 years ago • 2 comments
trafficstars

What this PR does: Add a toggle to enable/disable access logs in nginx (similar to loki helm chart)

Which issue(s) this PR fixes: Nothing

Checklist

  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

TuTuRyYE avatar Oct 05 '22 12:10 TuTuRyYE

I'm not used to contributing, this is my first time. Thanks for your help :)

TuTuRyYE avatar Oct 06 '22 12:10 TuTuRyYE

I'm not used to contributing, this is my first time. Thanks for your help :)

Absolutely not a problem. Thank you for your contribution

nschad avatar Oct 06 '22 13:10 nschad

Hey @TuTuRyYE,

I shouldn't have pressed the GitHub "update-repo" button. What a mess. Anyway... DCO seems to be stuck. Can you do the following on your PC in your cortex-helm-chart repo?

UNLESS YOU HAVE LOCAL CHANGES IN THAT BRANCH

# Assuming origin is your remote name
git fetch origin add_logging_verbose_option_to_nginx
git reset --hard origin/add_logging_verbose_option_to_nginx
# e2de2f1f3dd1ecb95762851cf96c512027b71e8f should be last commit ID from master. Your branch is already rebased. This should clean up any potential weird authors.
git rebase -i e2de2f1f3dd1ecb95762851cf96c512027b71e8f -x "git commit --amend --reset-author -CHEAD"
# push it
git push -u origin add_logging_verbose_option_to_nginx -f

nschad avatar Oct 17 '22 08:10 nschad