Rigbox icon indicating copy to clipboard operation
Rigbox copied to clipboard

Published 20 hours ago • verified publisher icon cortex-lab

SignalsExp as subclass

Open k1o0 opened this issue 5 years ago • 2 comments

MATLAB's moved on considerably since Chris implemented his performance tweaks to SignalsExp for performance. Once a performance test is in place for SignalsExp (#66) we can test the impact to performance when returning to a more intuitive OOP design, namely restoring use of hw.Window in SignalsExp and reducing code redundancy by making SignalsExp a subclass of Experiment. I expect the former may have the bigger impact on performance.

k1o0 avatar Oct 31 '19 09:10 k1o0

what were Chris' tweaks to exp.SignalsExp and how did they improve performance? I gather one was having srv.expServer create the PTB Screen rather than exp.SignalsExp?

jkbhagatio avatar Oct 31 '19 23:10 jkbhagatio

I gather one was having srv.expServer create the PTB Screen rather than exp.SignalsExp

No, expServer always initialized the hardware, including the PTB Window.

what were Chris' tweaks to exp.SignalsExp

There were many but mostly it was reducing the number of method calls because this used to be very slow.

k1o0 avatar Nov 01 '19 11:11 k1o0