Cortex-Command-Community-Project icon indicating copy to clipboard operation
Cortex-Command-Community-Project copied to clipboard

Convert Crab Bombs into a Global Script

Open Causeless opened this issue 1 year ago • 3 comments

Describe the Problem and Suggested Improvement Crab bombing was an effect caused by old technical limitations to the game that were removed a long, long time ago. Effectively, the combination of crabs being free with very restrictive MOID limit meant that spamming crabs would quickly blow this limit, causing all non-brain actors to gib.

In CCCP build, this was readded to the code as an explicit 'feature' for nostalgia purposes, but it's such a specific detail that it ought to be removed from the C++ entirely and done via script.

Describe Additional Work Required Before Improvement Can be Made The old crab bomb settings will need to be removed from SettingsMan, and have the vestigial crab bomb C++ hacks removed. Afterwards, a global script can be created that, when enabled, will re-introduce the crab bomb behaviour.

Note that global scripts, as of yet, lack the ability to have user-variable settings, e.g the crab bomb threshold. I suggest that the theshold is just set to its default value of 42 in the script.

Additional context The commit that added the crab bombs was ce87d4051b6f25cf0c3fcac60f937b5018828a85.

Causeless avatar Mar 05 '24 12:03 Causeless

Has Already been implemented if i am not mistaken #https://github.com/cortex-command-community/Cortex-Command-Community-Project/blame/394855b9bfe8e3c312fb310619dede4478511f71/Data/Base.rte/GUIs/SettingsGUI.ini#L3489

OpenTools-run avatar May 31 '25 02:05 OpenTools-run

That's a different thing. This task is referring to deleting the hack out of the codebase for this and using a global script instead.

Causeless avatar May 31 '25 11:05 Causeless

That's a different thing. This task is referring to deleting the hack out of the codebase for this and using a global script instead.

you are right, i have misread it earlier

OpenTools-run avatar May 31 '25 11:05 OpenTools-run