rioxarray icon indicating copy to clipboard operation
rioxarray copied to clipboard

BUG: Allow write_gcps to succeed without gcp_crs

Open peterm790 opened this issue 2 years ago • 5 comments
trafficstars

  • [x] Closes https://github.com/corteva/rioxarray/issues/646
  • [ ] Tests added
  • [x] Fully documented, including docs/history.rst for all changes and docs/rioxarray.rst for new API

I have not written any tests related to this change.

peterm790 avatar Mar 10 '23 11:03 peterm790

Mind adding a test similar to this one with the CRS = None? https://github.com/corteva/rioxarray/blob/205052675b2e2d070a699aa55359806e894e39ec/test/integration/test_integration_rioxarray.py#L2924

snowman2 avatar Mar 10 '23 18:03 snowman2

I have added a test, let me know if this is what you had in mind :thumbsup:

peterm790 avatar Mar 13 '23 10:03 peterm790

I have added a test, let me know if this is what you had in mind

Looks good :+1:. Once the linting issues are resolved, I think this is ready to merge.

snowman2 avatar Mar 13 '23 18:03 snowman2

Suggestion for fixing the linting issues:

python -m pip install pre-commit
pre-commit run --all

snowman2 avatar Mar 13 '23 18:03 snowman2

This PR just made it possible for me to read MODIS data into an xarray.Dataset. Thank you! Logs are expired on the checks, but I hope this can get patched and merged. You are amazing.

itcarroll avatar Jun 13 '23 20:06 itcarroll

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.99%. Comparing base (ae6635a) to head (2824264). Report is 90 commits behind head on master.

:exclamation: Current head 2824264 differs from pull request most recent head 4f4294b

Please upload reports for the commit 4f4294b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   95.90%   95.99%   +0.08%     
==========================================
  Files          12       12              
  Lines        1735     1748      +13     
==========================================
+ Hits         1664     1678      +14     
+ Misses         71       70       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 24 '24 19:06 codecov[bot]

Thanks @peterm790 :+1:

snowman2 avatar Jun 24 '24 20:06 snowman2