care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

fix: Update tooltip position and rotation in Discussion Notes panel

Open shauryag2002 opened this issue 1 year ago β€’ 1 comments

Proposed Changes

  • Fixes #8937
  • Corrected the conditional class name for tooltip rotation.
  • Ensured consistent tooltip positioning based on the show state. image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

shauryag2002 avatar Oct 27 '24 12:10 shauryag2002

Deploy Preview for care-ohc ready!

Name Link
Latest commit af5a4f883d31add993545c4683a9e5eb6795210f
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/672244369c7e030008adb5e5
Deploy Preview https://deploy-preview-8938--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 27 '24 12:10 netlify[bot]

LGTM

nihal467 avatar Nov 04 '24 21:11 nihal467

@coderabbitai full review

bodhish avatar Nov 05 '24 10:11 bodhish

:white_check_mark: Actions performed

Full review triggered.

coderabbitai[bot] avatar Nov 05 '24 10:11 coderabbitai[bot]

Walkthrough

The changes in PatientNotesSlideover.tsx involve updates to the rendering logic and state management for displaying patient notes. The show state variable is now utilized to conditionally render icons and tooltips for minimizing and closing the notes section. Icon toggling and tooltip text adjustments enhance user interaction. The core functionality, including error handling and notification management, remains unchanged, while minor class name adjustments improve tooltip visibility based on the notes section's state.

Changes

Files Change Summary
src/components/Facility/PatientNotesSlideover.tsx Modified rendering logic for tooltips and icons based on show state; adjusted tooltip text and class names; retained core functionality and error handling.

Assessment against linked issues

Objective Addressed Explanation
The "Minimize" tooltip should display horizontally and align correctly above or below the button. (8937) βœ…
The "Close" tooltip should remain fully visible within the screen boundaries. (8937) βœ…

Possibly related PRs

  • #8972: The changes in this PR also focus on enhancing the user interface through tooltip features, similar to the modifications made in PatientNotesSlideover.tsx for displaying dynamic tooltip text based on state.

Poem

πŸ‡ In the notes where patients dwell,
Tooltips now align and tell,
With icons bright, they rise and fall,
A better view for one and all!
So hop along, let’s celebrate,
A UI change that feels just great! 🌟


πŸ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between a0e6e621260a3501e3828c3ad9f14ae7efd3d94f and af5a4f883d31add993545c4683a9e5eb6795210f.

πŸ“’ Files selected for processing (1)
  • src/components/Facility/PatientNotesSlideover.tsx (2 hunks)
πŸ”‡ Additional comments (3)
src/components/Facility/PatientNotesSlideover.tsx (3)

160-162: LGTM! Icon state correctly reflects panel state.

The icon toggle between "l-angle-down" and "l-angle-up" based on the show state provides clear visual feedback about the panel's state.


163-169: LGTM! Tooltip positioning is now correctly handled.

The tooltip positioning has been improved by:

  • Using classNames utility for better class management
  • Conditionally applying position and translation based on panel state
  • Ensuring tooltip remains visible in both expanded and minimized states

180-187: LGTM! Close tooltip visibility is fixed.

The close tooltip implementation follows the same pattern as the minimize tooltip, ensuring consistent behavior and visibility in both expanded and minimized states.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Nov 05 '24 10:11 coderabbitai[bot]

@khavinshankar your review required

rithviknishad avatar Nov 10 '24 03:11 rithviknishad

@shauryag2002 Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar Nov 11 '24 06:11 github-actions[bot]