care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Add a cypress test to assign a volunteer to a patient

Open nihal467 opened this issue 1 year ago • 2 comments

Description

Add a new cypress test to assign a volunteer to an existing live patient

General Note

  1. Follow the Page Object Model (POM) approach. : reference
  2. Refer to commands.ts in the Cypress folder to understand existing reusable components.
  3. Use proper function names for easier code review. 4.Since there's nothing related to volunteers currently, create a new file named PatientVolunteer.cy.ts under the patient_spec folder.

Steps to Assign a volunteer

  1. Go to the patient tab
  2. click on any live patient card
  3. On the patient consultation page, click the Patient Details button in the top-right corner
  4. Once the new page loads, scroll down to the Assign New Volunteer button.
  5. Assign a new volunteer to the patient.
  6. Ensure the newly added volunteer's name is displayed as a banner at the top of the patient details page.

Make sure to verify the below things

  1. Ensure the normal workflow is functional.
  2. Replace the existing volunteer with a new one and verify the banner shows the new volunteer's name.
  3. When the volunteer is removed and left blank, verify that the banner is no longer displayed.

nihal467 avatar Oct 24 '24 07:10 nihal467

@nihal467 Can I work on this? Please assign it me.

sidpg123 avatar Oct 24 '24 12:10 sidpg123

Hi @nihal467 ,

All tasks mentioned in the issue have been completed as per the requirements:

  • Created a new Cypress test under patient_spec/PatientVolunteer.cy.ts to assign a volunteer to an existing live patient.
  • Since there wasn’t an existing class for the Patient Details page, I created one PatientDetails.ts and added required functions.
  • Replace Existing Volunteer: Tested replacing an existing volunteer and verified the updated name appears in the banner.
  • Remove Volunteer: Verified that removing the volunteer hides the banner as expected.

Additionally, I added an id to the banner component for easier targeting.

Please review the changes and let me know if any adjustments are needed.

Thanks!

Patient Details Class:

Image

Test

Image

Added id to banner:

Image

sidpg123 avatar Oct 27 '24 17:10 sidpg123

Hey @sidpg123 are you working on this issue?

JavidSumra avatar Nov 06 '24 04:11 JavidSumra

@JavidSumra yes, i am working on the issue infact work is almost done , i am waiting for @nihal467 confirmation.

sidpg123 avatar Nov 07 '24 13:11 sidpg123

@sidpg123 for review purpose, raise the PR

nihal467 avatar Nov 07 '24 14:11 nihal467

@sidpg123 unassigning you from the issue due to inactivity

nihal467 avatar Nov 19 '24 08:11 nihal467

Hey @nihal467 can you please assign this issue to me?

JavidSumra avatar Nov 19 '24 08:11 JavidSumra

@nihal467 Sorry for my inactivity. I have completed the code, but I forgot to raise a PR. If you give me permission, I will raise it immediately.

sidpg123 avatar Nov 19 '24 13:11 sidpg123

@sidpg123 do raise a PR.

bodhish avatar Nov 19 '24 14:11 bodhish