Fixing NotificationsList on Service Worker

[vishwansh01]

Proposed Changes

• Fixes #8006
• Added Type Check for Service Worker and Push Manager
• Added a try-catch block around the subscription status check logic within intialSubscriptionState function.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• [ ] Add specs that demonstrate bug / test a new feature.
• [ ] Update product documentation.
• [ ] Ensure that UI text is kept in I18n files.
• [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
• [ ] Request for Peer Reviews
• [ ] Completion of QA

[netlify[bot]]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	d02281da29f1b92f90819de38294c5d56f09df0d
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/671e5c17bf9e9f0008f7783d
😎 Deploy Preview	https://deploy-preview-8686--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nihal467]

LGTM

[bodhish]

@vishwansh01 can you update the status here?

[AdityaJ2305]

Hey @bodhish, Since @vishwansh01 hasn’t responded to the requested changes on the PR, can I create a new PR for this issue if he remains inactive?

[bodhish]

@vishwansh01 will you be working on this issue?

[vishwansh01]

@bodhish yes I am working

[khavinshankar]

@vishwansh01 fix the linting errors

[github-actions[bot]]

:wave: Hi, @vishwansh01, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

---

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

[github-actions[bot]]

:wave: Hi, @vishwansh01, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

---

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

[bodhish]

@vishwansh01 let me know when its up for review.

[bodhish]

@coderabbitai full review

[coderabbitai[bot]]

:white_check_mark: Actions performed

Full review triggered.

[coderabbitai[bot]]

Walkthrough

The changes in the NotificationsList.tsx component focus on improving subscription management and notification state handling. Key updates include enhanced subscription logic that checks for the availability of the service worker, refined error handling during unsubscription, and streamlined state management for subscription status. While the core functionality for marking notifications as read or unread remains unchanged, the overall structure has been adjusted to ensure robustness and prevent runtime errors.

Changes

File Path	Change Summary
src/components/Notifications/NotificationsList.tsx	Updated subscription logic to check for navigator.serviceWorker, refined error handling in unsubscription, streamlined state management for isSubscribing, and maintained notification handling logic.

Assessment against linked issues

Objective	Addressed	Explanation
Safely check for service worker availability and handle undefined subscription object (8006)	✅

🐇 In the meadow, notifications bloom,
With checks for service workers, no more gloom!
Errors are tamed, and states align,
A robust solution, oh how it shines!
Click and read, with joy we cheer,
For every update, we hold so dear! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions[bot]]

:wave: Hi, @vishwansh01, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

---

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

[sainak]

closing in favor of https://github.com/ohcnetwork/care_fe/pull/8935