care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Phone number field: Adds helper icon to improve how supported phone number types are shown

Open rithviknishad opened this issue 1 year ago • 3 comments

Proposed Changes

  • Fixes #8051
  • Adds a utility fn. to humanize array of strings (join with ',' and 'and')
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

rithviknishad avatar Jul 08 '24 13:07 rithviknishad

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:12am

vercel[bot] avatar Jul 08 '24 13:07 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 1e4aefff2200ddf731f5ec01a6acda07aae42edd
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/668e0a0841289900080589ef
Deploy Preview https://deploy-preview-8126--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 08 '24 13:07 netlify[bot]

Passing run #2837 ↗︎

0 126 0 0 Flakiness 0

Details:

Phone number field: Adds helper icon to improve how supported phone number types...
Project: CARE Commit: 1e4aefff22
Status: Passed Duration: 03:07 💡
Started: Jul 10, 2024 4:16 AM Ended: Jul 10, 2024 4:19 AM

Review all test suite changes for PR #8126 ↗︎

cypress[bot] avatar Jul 08 '24 13:07 cypress[bot]

@rithviknishad image

can we use the above screenshot icon for this purpose, to keep design consistency

nihal467 avatar Jul 09 '24 07:07 nihal467

I've instead updated the icon in the user create page to be question mark and ensured all other usages are correct.

The question mark icon is more appropriate for "need help".

rithviknishad avatar Jul 09 '24 07:07 rithviknishad

@rithviknishad image

the tooltip is clipping out

nihal467 avatar Jul 09 '24 07:07 nihal467

LGTM

nihal467 avatar Jul 09 '24 08:07 nihal467

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar Jul 11 '24 07:07 github-actions[bot]