care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Shows encounter duration in discharge confirmation dialog

Open rithviknishad opened this issue 1 year ago • 3 comments

Proposed Changes

  • Fixes #8121
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

rithviknishad avatar Jul 08 '24 12:07 rithviknishad

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:36am

vercel[bot] avatar Jul 08 '24 12:07 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 6f2e32078d7088b763b9275e4a44513f71b0276a
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/668d04887d9e110008c6f456
Deploy Preview https://deploy-preview-8124--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 08 '24 12:07 netlify[bot]

Passing run #2834 ↗︎

0 126 0 0 Flakiness 0

Details:

Shows encounter duration in discharge confirmation dialog
Project: CARE Commit: 6f2e32078d
Status: Passed Duration: 03:09 💡
Started: Jul 9, 2024 9:40 AM Ended: Jul 9, 2024 9:43 AM

Review all test suite changes for PR #8124 ↗︎

cypress[bot] avatar Jul 08 '24 12:07 cypress[bot]

image image

@rithviknishad the IP no of patients are shown as 24 days and in the discharge pop-up it is shown as 25 days, how are we calculating the no of days, is it based on 24 hours clock from the date of admission or is it per night, we need to clarify it with @aparnacoronasafe and modify the PR based on the logic finalised . My suggestion its better to keep logic based on how rooms days are calculated in hospital as we are moving towards billing and schedule

nihal467 avatar Jul 09 '24 07:07 nihal467

@nihal467

As discussed with @aparnacoronasafe , we've decided to show the n'th day (i.e. the logic in the discharge popup is correct and the IP Days number needs to be incremented by 1)

i.e.: For first 24 hours: days would be 1 For 24-48th hour: days would be 2 and so on.

rithviknishad avatar Jul 09 '24 09:07 rithviknishad

LGTM

nihal467 avatar Jul 11 '24 06:07 nihal467

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar Jul 11 '24 06:07 github-actions[bot]