care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Events: Adds support for filtering by event types

Open rithviknishad opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe. Currently it is not possible to filter events by event types.

Describe the solution you'd like Add a multi select filter in the events list to filter by one or more event types.

https://care.ohc.network/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/edfe0bd6-0f50-4a4c-8cd0-2d4ad0e9cea1

image

rithviknishad avatar May 22 '24 07:05 rithviknishad

Hi @rithviknishad Can you provide me a high level view on how to get started on this? Also, I wanna work on it, may i?

Atharva-Kanherkar avatar May 26 '24 12:05 Atharva-Kanherkar

Hey @Atharva-Kanherkar

Yes you can work on this!

Solution 1

To get the list of available event types, you'll need to fetch the event types from the API: https://careapi.ohc.network/swagger/#/event_types

And then when fetching consultation events, pass the event type id to the filter. https://careapi.ohc.network/swagger/#/events/api_v1_consultation_events_list

You might want to update the backend to support filtering by multiple event type ID's.

Solution 2 (preferred)

Same as solution 1, except that instead of fetching the event types from API, change the consultation events filter to filter by event names instead.

cc: @sainak

rithviknishad avatar May 28 '24 07:05 rithviknishad

The UI could be kept similar to the filter popover present in the daily rounds filter. Feel free to suggest better alternatives if you have any in mind!

image

rithviknishad avatar May 28 '24 07:05 rithviknishad

The UI could be kept similar to the filter popover present in the daily rounds filter. Feel free to suggest better alternatives if you have any in mind!

image

Sure! Just give me some time to get to understand the codebase better. I am very interested to contribute to the next js frontend. Please bear with me as I progress. Thank you so much .

Atharva-Kanherkar avatar May 28 '24 07:05 Atharva-Kanherkar

Sure! Feel free to drop a comment if you are facing any difficulty understanding something.

rithviknishad avatar May 28 '24 07:05 rithviknishad

@Atharva-Kanherkar Well , if you get stuck at something , do share . Will help if I can...

Sulochan-khadka avatar Jun 11 '24 15:06 Sulochan-khadka

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

github-actions[bot] avatar Jun 27 '24 04:06 github-actions[bot]

@Atharva-Kanherkar unassigning due to no activity.

rithviknishad avatar Aug 12 '24 05:08 rithviknishad

Alright sir

On Mon, 12 Aug, 2024, 11:20 am Rithvik Nishad, @.***> wrote:

@Atharva-Kanherkar https://github.com/Atharva-Kanherkar unassigning due to no activity.

— Reply to this email directly, view it on GitHub https://github.com/coronasafe/care_fe/issues/7877#issuecomment-2283155517, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB6XMZ5M23NGP7RWJ2M5CTLZRBEKNAVCNFSM6AAAAABJESO2Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTGE2TKNJRG4 . You are receiving this because you were mentioned.Message ID: @.***>

Atharva-Kanherkar avatar Aug 12 '24 07:08 Atharva-Kanherkar

@sainak doesn this have a linked PR?

bodhish avatar Nov 25 '24 05:11 bodhish

@bodhish this was blocked by https://github.com/ohcnetwork/care/issues/2598

sainak avatar Nov 25 '24 06:11 sainak

not a requirement based on the current develop

nihal467 avatar Dec 31 '24 09:12 nihal467