care_fe
care_fe copied to clipboard
Removed Oxygen Details from Update Facility form
Proposed Changes
- Fixes #7758
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.
- [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
- [ ] Request for Peer Reviews
- [ ] Completion of QA
@609harsh is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.
A member of the Team first needs to authorize it.
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | eb939dcf319a166745c7e6e8462f6631b9754adf |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/665aeafed3120500084327ea |
Deploy Preview | https://deploy-preview-7796--care-egov-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@609harsh modify the existing cypress test related to facility creation as it is currently failing
:wave: Hi, @609harsh, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
Hi @rithviknishad these are the following updates in ui
on Update Facility page
@609harsh modify the existing cypress test related to facility creation as it is currently failing
Please review the modified cypress test
@609harsh
- [ ] when we open the add oxygen pop-up, the input field are having 0 as by-default value, it should be blank input , similar to the staff and bed capacity pop-up we have
- [ ] Already added oxygen type, should be hidden in the dropdown of oxygen type
- [ ] when we are editing pop-up of oxygen detail, disable the oxygen type as we wont be changing it, similar to the staff capacity pop-up
- [ ] when we click on the save and add more button, it shouldn't close the pop-up similar to the staff capacity pop-up
Note: Always try to check the similar existing behavior functions (staff capacity pop-up or bed capacity pop-up), in the platform and do a basic functionality check to increase the quality of PR
:wave: Hi, @609harsh, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
hi @nihal467 regarding the last query currently i am sending down props from parent to use oxygen related. In order to prevent popup closing we need a new endpoint to fetch and update information related to oxygen only (similar to what is followed in staff capacity pop-up or bed capacity pop-up). Please refer to this issue's thread https://github.com/coronasafe/care_fe/issues/7758#issuecomment-2098715756
@609harsh you could simply pass the refetch callback from the useQuery and call that instead to refresh latest information.
:wave: Hi, @609harsh, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@609harsh Can you update the PR?
Closing this PR due to lack of recent progress.