care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Removed Oxygen Details from Update Facility form

Open 609harsh opened this issue 9 months ago • 10 comments

Proposed Changes

  • Fixes #7758

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

609harsh avatar May 11 '24 12:05 609harsh

@609harsh is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 11 '24 12:05 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit eb939dcf319a166745c7e6e8462f6631b9754adf
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/665aeafed3120500084327ea
Deploy Preview https://deploy-preview-7796--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 11 '24 12:05 netlify[bot]

@609harsh modify the existing cypress test related to facility creation as it is currently failing

nihal467 avatar May 14 '24 19:05 nihal467

:wave: Hi, @609harsh, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar May 15 '24 06:05 github-actions[bot]

Hi @rithviknishad these are the following updates in ui

image image image image

on Update Facility page image

609harsh avatar May 15 '24 14:05 609harsh

@609harsh modify the existing cypress test related to facility creation as it is currently failing

Please review the modified cypress test

609harsh avatar May 20 '24 07:05 609harsh

@609harsh

image

  • [ ] when we open the add oxygen pop-up, the input field are having 0 as by-default value, it should be blank input , similar to the staff and bed capacity pop-up we have

image

  • [ ] Already added oxygen type, should be hidden in the dropdown of oxygen type

image

  • [ ] when we are editing pop-up of oxygen detail, disable the oxygen type as we wont be changing it, similar to the staff capacity pop-up

image

  • [ ] when we click on the save and add more button, it shouldn't close the pop-up similar to the staff capacity pop-up

Note: Always try to check the similar existing behavior functions (staff capacity pop-up or bed capacity pop-up), in the platform and do a basic functionality check to increase the quality of PR

nihal467 avatar May 28 '24 06:05 nihal467

:wave: Hi, @609harsh, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar May 29 '24 06:05 github-actions[bot]

hi @nihal467 regarding the last query currently i am sending down props from parent to use oxygen related. In order to prevent popup closing we need a new endpoint to fetch and update information related to oxygen only (similar to what is followed in staff capacity pop-up or bed capacity pop-up). Please refer to this issue's thread https://github.com/coronasafe/care_fe/issues/7758#issuecomment-2098715756

609harsh avatar Jun 01 '24 09:06 609harsh

@609harsh you could simply pass the refetch callback from the useQuery and call that instead to refresh latest information.

rithviknishad avatar Jun 05 '24 07:06 rithviknishad

:wave: Hi, @609harsh, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Jul 16 '24 12:07 github-actions[bot]

@609harsh Can you update the PR?

gigincg avatar Aug 05 '24 09:08 gigincg

Closing this PR due to lack of recent progress.

bodhish avatar Sep 20 '24 15:09 bodhish