care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Added facility hubs

Open shivankacker opened this issue 9 months ago • 8 comments

Proposed Changes

  • Fixes #7583
  • Adds a new multiselect field in facility form to define any hubs of the facility if present

backend : https://github.com/coronasafe/care/pull/2135 @coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

shivankacker avatar May 08 '24 00:05 shivankacker

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 6:15pm

vercel[bot] avatar May 08 '24 00:05 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 138169e50e8fba6ba6a8237ac3dbe933e52faf1c
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c83faa1eb76e000874fca1
Deploy Preview https://deploy-preview-7772--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 08 '24 00:05 netlify[bot]

CARE    Run #3343

Run Properties:  status check passed Passed #3343  •  git commit a956703f1e: Added facility hubs
Project CARE
Branch Review facility-hubs
Run status status check passed Passed #3343
Run duration 02m 59s
Commit git commit a956703f1e: Added facility hubs
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 128
View all changes introduced in this branch ↗︎

cypress[bot] avatar May 08 '24 01:05 cypress[bot]

@skks1212 image

  • [ ] currently, it is a click and select dropdown, change it the component, where users can type and select from the dropdown the respective facility
  • [ ] currently, it is not reflected anywhere in the facility details page, we should be reflecting the data somewhere in the details page : take an opinion from @aparnacoronasafe for the UI approval

nihal467 avatar May 14 '24 19:05 nihal467

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar May 22 '24 04:05 github-actions[bot]

:wave: Hi, @skks1212, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar May 28 '24 11:05 github-actions[bot]

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar Jun 05 '24 04:06 github-actions[bot]

discussion is still going on, so marking the PR to hold

nihal467 avatar Jun 13 '24 04:06 nihal467

:wave: Hi, @skks1212, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Jul 11 '24 07:07 github-actions[bot]

@skks1212 any update on this PR

nihal467 avatar Jul 30 '24 19:07 nihal467

@nihal467 this is on hold right?

shivankacker avatar Jul 30 '24 22:07 shivankacker

@shivankacker Changes Required on Backend

gigincg avatar Aug 25 '24 14:08 gigincg

@shivankacker @gigincg

Please note that a spoke could also have multiple hubs.

There can be 1 general hub, 1 MCH hub, another cardiology hub, cancer hub etc for the same spoke.

Hope this is accounted for in this change.

Currently in Meghalaya we have 2 hubs , 1 general and 1 specifically for MCH (mother and child health)

aparnacoronasafe avatar Aug 26 '24 09:08 aparnacoronasafe

@aparnacoronasafe what is the functional requirement here?

I understand how the linking can be helpful but what will be the feature it powers?

bodhish avatar Aug 26 '24 09:08 bodhish

@aparnacoronasafe what is the functional requirement here?

I understand how the linking can be helpful but what will be the feature it powers?

@bodhish

Going ahead I think having these linkages would help streamline user management. Staff at the hubs will be identified in diff departments. The relevant departments must have the right access to the patients in the spokes. This flow will be streamlined once we capture the hub-spoke linkage on CARE accurately.

This is the reason we are capturing the hub-spoke relation in the first place. It would be ineffective if we assume that there is always 1 hub for every spoke.

aparnacoronasafe avatar Aug 27 '24 07:08 aparnacoronasafe

The implementation doesn't assume 1 hub per facility.

This should have been developed as part of a feature than doing it assuming a usecase would come up.

bodhish avatar Aug 27 '24 07:08 bodhish

Deploy Preview for care-ohc ready!

Name Link
Latest commit a956703f1e375c0a36e2fe1ccc814c4ecf40568e
Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e495ba49c7820008678c93
Deploy Preview https://deploy-preview-7772--care-ohc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 30 '24 00:08 netlify[bot]

@bodhish @aparnacoronasafe should I go ahead with implementing this or is there a blocker?

shivankacker avatar Aug 30 '24 01:08 shivankacker

Please go ahead @shivankacker

aparnacoronasafe avatar Sep 02 '24 10:09 aparnacoronasafe

@shivankacker

image

  • [ ] the component is not properly mobile responsive, users are not able to see the input characters in the mobile view
  • [ ] add a proper description for the issue, what are the options we are adding, currently i can view only regular and Tele ICU , is that the only option were expected to be added ? add more description on the issue as well as in the PR for review purpose

image

@skks1212 image

  • [ ] currently, it is a click and select dropdown, change it the component, where users can type and select from the dropdown the respective facility
  • [ ] currently, it is not reflected anywhere in the facility details page, we should be reflecting the data somewhere in the details page : take an opinion from @aparnacoronasafe for the UI approval
  • [ ] As mentioned in the Previous comment, we are not at all showing anywhere in the dashboard below things:
  • how many spokes are linked to a hub facility
  • which all facility are hub facility , add a option to mark a facility as hub or spoke, so later on we can filter hub and spoke facility in future
  • we need a location in the facility details page, where we show these details , can you check with @aparnacoronasafe once on the above comments

image

  • [ ] Assuming that Dummy Facility A is the hub for Dummy Facility B, can you confirm that if Dummy Facility C can be the hub for Dummy Facility A, given that A is already a hub for B and therefore cannot be a spoke under Facility C?

nihal467 avatar Sep 02 '24 11:09 nihal467

@nihal467 I have fixed the responsiveness issue and displayed the spoke relationship on the facility home page after consulting Aparna. She says that a spoke can be a hub to other spokes.

shivankacker avatar Sep 02 '24 13:09 shivankacker

LGTM

nihal467 avatar Sep 02 '24 18:09 nihal467

:wave: Hi, @shivankacker, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Sep 03 '24 18:09 github-actions[bot]

@nihal467 @shivankacker Whats pending here?

bodhish avatar Sep 19 '24 14:09 bodhish

@bodhish Waiting for Backend

shivankacker avatar Sep 19 '24 15:09 shivankacker

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar Sep 24 '24 15:09 github-actions[bot]