care_fe
care_fe copied to clipboard
Added facility hubs
Proposed Changes
- Fixes #7583
- Adds a new multiselect field in facility form to define any hubs of the facility if present
backend : https://github.com/coronasafe/care/pull/2135 @coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
care-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 30, 2024 6:15pm |
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | 138169e50e8fba6ba6a8237ac3dbe933e52faf1c |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/66c83faa1eb76e000874fca1 |
Deploy Preview | https://deploy-preview-7772--care-egov-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
CARE
Run #3343
Run Properties:
Passed #3343
•
a956703f1e: Added facility hubs
Project |
CARE
|
Branch Review |
facility-hubs
|
Run status |
|
Run duration | 02m 59s |
Commit |
|
Committer | Shivank Kacker |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
128
|
View all changes introduced in this branch ↗︎ |
@skks1212
- [ ] currently, it is a click and select dropdown, change it the component, where users can type and select from the dropdown the respective facility
- [ ] currently, it is not reflected anywhere in the facility details page, we should be reflecting the data somewhere in the details page : take an opinion from @aparnacoronasafe for the UI approval
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
:wave: Hi, @skks1212, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
discussion is still going on, so marking the PR to hold
:wave: Hi, @skks1212, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@skks1212 any update on this PR
@nihal467 this is on hold right?
@shivankacker Changes Required on Backend
@shivankacker @gigincg
Please note that a spoke could also have multiple hubs.
There can be 1 general hub, 1 MCH hub, another cardiology hub, cancer hub etc for the same spoke.
Hope this is accounted for in this change.
Currently in Meghalaya we have 2 hubs , 1 general and 1 specifically for MCH (mother and child health)
@aparnacoronasafe what is the functional requirement here?
I understand how the linking can be helpful but what will be the feature it powers?
@aparnacoronasafe what is the functional requirement here?
I understand how the linking can be helpful but what will be the feature it powers?
@bodhish
Going ahead I think having these linkages would help streamline user management. Staff at the hubs will be identified in diff departments. The relevant departments must have the right access to the patients in the spokes. This flow will be streamlined once we capture the hub-spoke linkage on CARE accurately.
This is the reason we are capturing the hub-spoke relation in the first place. It would be ineffective if we assume that there is always 1 hub for every spoke.
The implementation doesn't assume 1 hub per facility.
This should have been developed as part of a feature than doing it assuming a usecase would come up.
Deploy Preview for care-ohc ready!
Name | Link |
---|---|
Latest commit | a956703f1e375c0a36e2fe1ccc814c4ecf40568e |
Latest deploy log | https://app.netlify.com/sites/care-ohc/deploys/66e495ba49c7820008678c93 |
Deploy Preview | https://deploy-preview-7772--care-ohc.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@bodhish @aparnacoronasafe should I go ahead with implementing this or is there a blocker?
Please go ahead @shivankacker
@shivankacker
- [ ] the component is not properly mobile responsive, users are not able to see the input characters in the mobile view
- [ ] add a proper description for the issue, what are the options we are adding, currently i can view only regular and Tele ICU , is that the only option were expected to be added ? add more description on the issue as well as in the PR for review purpose
@skks1212
- [ ] currently, it is a click and select dropdown, change it the component, where users can type and select from the dropdown the respective facility
- [ ] currently, it is not reflected anywhere in the facility details page, we should be reflecting the data somewhere in the details page : take an opinion from @aparnacoronasafe for the UI approval
- [ ] As mentioned in the Previous comment, we are not at all showing anywhere in the dashboard below things:
- how many spokes are linked to a hub facility
- which all facility are hub facility , add a option to mark a facility as hub or spoke, so later on we can filter hub and spoke facility in future
- we need a location in the facility details page, where we show these details , can you check with @aparnacoronasafe once on the above comments
- [ ] Assuming that Dummy Facility A is the hub for Dummy Facility B, can you confirm that if Dummy Facility C can be the hub for Dummy Facility A, given that A is already a hub for B and therefore cannot be a spoke under Facility C?
@nihal467 I have fixed the responsiveness issue and displayed the spoke relationship on the facility home page after consulting Aparna. She says that a spoke can be a hub to other spokes.
LGTM
:wave: Hi, @shivankacker, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@nihal467 @shivankacker Whats pending here?
@bodhish Waiting for Backend
@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: