care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Hide Facility link and unlink button for non-admin users

Open Pranshu1902 opened this issue 9 months ago • 12 comments

Proposed Changes

  • Fixes #7604 Hide the Facility link and unlink button for non-admin users.

Hide Clear Home Facility button: image

Give Error notification for link and unlink buttons image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

Pranshu1902 avatar Apr 29 '24 15:04 Pranshu1902

@Pranshu1902 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 29 '24 15:04 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 4f308305791bfbd7dfca33d993fc70e2a0b0f4de
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66558bb62816c00008469066
Deploy Preview https://deploy-preview-7738--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 29 '24 15:04 netlify[bot]

:wave: Hi, @Pranshu1902, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Apr 30 '24 05:04 github-actions[bot]

@Pranshu1902

image

above is the current stage screenshot

image

above is the PR deployment

  • the PR is not showing the home facility page, can you check into this issue and reverify the code change you made while clearing the merge conflict

nihal467 avatar May 07 '24 14:05 nihal467

@nihal467 resolved the conflicts updated view: image

Pranshu1902 avatar May 07 '24 14:05 Pranshu1902

@Pranshu1902 image

as per the issue, the button was suggested to be hidden, as non-admin users have no privilege to use it

nihal467 avatar May 08 '24 08:05 nihal467

:wave: Hi, @Pranshu1902, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar May 08 '24 11:05 github-actions[bot]

@nihal467 Updated view: image

Pranshu1902 avatar May 08 '24 13:05 Pranshu1902

@Pranshu1902 blocking it for further clarification from @aparnacoronasafe

nihal467 avatar May 16 '24 18:05 nihal467

@Pranshu1902 can you modify the PR based on the latest expected behavior

nihal467 avatar May 17 '24 11:05 nihal467

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar May 25 '24 04:05 github-actions[bot]

@nihal467 done image

Pranshu1902 avatar May 25 '24 19:05 Pranshu1902

@Pranshu1902 image

  • [ ] admin are not able to see the unlink or link button, do recheck your PR and do basic functionality check before marking it for review

nihal467 avatar May 28 '24 06:05 nihal467

@nihal467 done

Admin View: image

Nurse View: image

Nurse View for their profile: image

Pranshu1902 avatar May 28 '24 07:05 Pranshu1902

@Pranshu1902

image

nurse is not able to clear his own home facility access

nihal467 avatar May 29 '24 06:05 nihal467

@nihal467 the backend is rejecting the request for nurse user type.

Raised a backend PR for that: #2206

Screenshot from 2024-05-29 13-22-05

Pranshu1902 avatar May 29 '24 07:05 Pranshu1902

LGTM

nihal467 avatar Jun 04 '24 12:06 nihal467

@nihal467 the backend PR has been merged

Pranshu1902 avatar Jun 13 '24 15:06 Pranshu1902

@Pranshu1902 Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar Jun 14 '24 01:06 github-actions[bot]