care_fe
care_fe copied to clipboard
Hide Facility link and unlink button for non-admin users
Proposed Changes
- Fixes #7604 Hide the Facility link and unlink button for non-admin users.
Hide Clear Home Facility button:
Give Error notification for link and unlink buttons
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.
- [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
- [ ] Request for Peer Reviews
- [ ] Completion of QA
@Pranshu1902 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.
A member of the Team first needs to authorize it.
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | 4f308305791bfbd7dfca33d993fc70e2a0b0f4de |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/66558bb62816c00008469066 |
Deploy Preview | https://deploy-preview-7738--care-egov-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
:wave: Hi, @Pranshu1902, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@Pranshu1902
above is the current stage screenshot
above is the PR deployment
- the PR is not showing the home facility page, can you check into this issue and reverify the code change you made while clearing the merge conflict
@nihal467 resolved the conflicts
updated view:
@Pranshu1902
as per the issue, the button was suggested to be hidden, as non-admin users have no privilege to use it
:wave: Hi, @Pranshu1902, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@nihal467 Updated view:
@Pranshu1902 blocking it for further clarification from @aparnacoronasafe
@Pranshu1902 can you modify the PR based on the latest expected behavior
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
@nihal467 done
@Pranshu1902
- [ ] admin are not able to see the unlink or link button, do recheck your PR and do basic functionality check before marking it for review
@nihal467 done
Admin View:
Nurse View:
Nurse View for their profile:
@Pranshu1902
nurse is not able to clear his own home facility access
@nihal467 the backend is rejecting the request for nurse user type.
Raised a backend PR for that: #2206
LGTM
@nihal467 the backend PR has been merged
@Pranshu1902 Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: