care_fe
care_fe copied to clipboard
coronasafe
Fix Notifications for Facility Cover Image Deletion
Proposed Changes
- Fixes #7595
- Fixing re-render issue
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.
- [x] Prep screenshot or demo video for changelog entry, and attach it to issue.
- [ ] Request for Peer Reviews
- [ ] Completion of QA
screenshot:
@AnkurPrabhu is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for care-egov-staging ready!
| Name | Link |
|---|---|
| Latest commit | 667136e3d7d98128fe472ef5d4dd61ddf68616c9 |
| Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/66b0c855691e85000801f443 |
| Deploy Preview | https://deploy-preview-7609--care-egov-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rithviknishad we already had notification for deletion its just that due to re-renders it does not show it. this should fix it
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@AnkurPrabhu can u also move the constants (that doesn't depend on any state) outside the function
@khavinshankar can you explain as in what do you mean by constants here
@rithviknishad @AnkurPrabhu Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: