care_fe
care_fe copied to clipboard
coronasafe
Fix Incorrect error message for invalid QR code
Proposed Changes
- Fixes #7571
- not calling the backend api when the QR code is invalid
- stop infinite loading screen when the QR code is invalid
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.
- [x] Prep screenshot or demo video for changelog entry, and attach it to issue.
- [ ] Request for Peer Reviews
- [ ] Completion of QA
SS:
@AnkurPrabhu is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for care-egov-staging ready!
| Name | Link |
|---|---|
| Latest commit | 25ab42a25c3cbdb735ae98ff62fcf0e976b04f74 |
| Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/66aa47af280a2700085a1280 |
| Deploy Preview | https://deploy-preview-7588--care-egov-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
:wave: Hi, @AnkurPrabhu, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
:wave: Hi, @AnkurPrabhu, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
@AnkurPrabhu remove the additional "something went wrong...!" error message , when we scan invalid QR
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
:wave: Hi, @AnkurPrabhu, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
Deploy Preview for care-net failed.
| Name | Link |
|---|---|
| Latest commit | d4833c66370fa55f3f3b31e564afe4dc33d8e0be |
| Latest deploy log | https://app.netlify.com/sites/care-net/deploys/66aa3f1c6bb59d000857d6ec |
@AnkurPrabhu Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: