care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

search by typing in symptoms

Open hrit2773 opened this issue 10 months ago • 6 comments

Proposed Changes

  • Fixes #7543

hrit2773 avatar Apr 05 '24 17:04 hrit2773

@hrit2773 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 05 '24 17:04 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 667bc05bf74b5ae8c80bda5add84e425932b2bfc
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6627bbb8a0211500082f85eb
Deploy Preview https://deploy-preview-7551--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 05 '24 17:04 netlify[bot]

@hrit2773 fix the cypress issue

nihal467 avatar Apr 06 '24 19:04 nihal467

  1. Patient Consultation in multiple combination OP Patient with admission consultation: AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it. at Context.eval (webpack://care_fe/./cypress/support/commands.ts:131:0)

  2. Patient Consultation in multiple combination OP Patient with Declare Death: AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it. at Context.eval (webpack://care_fe/./cypress/support/commands.ts:131:0)

  3. Patient Consultation in multiple combination Internal Transfer within facility Patient with Domicilary Care: AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it. at Context.eval (webpack://care_fe/./cypress/support/commands.ts:131:0)

  4. Patient Consultation in multiple combination Referred From another Facility Patient with OP consultation: AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it. at eval (webpack://care_fe/./cypress/support/commands.ts:122:0) at Array.forEach () at Context.eval (webpack://care_fe/./cypress/support/commands.ts:121:0)

  5. Patient Consultation in multiple combination OP Patient with Refer to another hospital consultation: AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it. at eval (webpack://care_fe/./cypress/support/commands.ts:122:0) at Array.forEach () at Context.eval (webpack://care_fe/./cypress/support/commands.ts:121:0)

@nihal467 what is this [role='option'] how to track them

hrit2773 avatar Apr 07 '24 05:04 hrit2773

@nihal i just made changes to autoCompleteMultiSelect component. I think this issue has nothing to do with the patient op declare death or domiciliary care. And i didnt make any changes to the field attributes or selectors, maybe cypress is unable to get the selectors of the components...just tell me if im missing something. Can you tell me more about these cypress tests configurations because the consultation form is working completely fine

hrit2773 avatar Apr 07 '24 06:04 hrit2773

image @hrit2773

  • [ ] Go to the patient_consultation.cy.ts file and modify the patientconsultationpage.selectsymptoms().
  • [ ] Since we don't have search and multi-select reusable selector components, create a component in the command.ts file for Cypress, and use it to select symptoms in the function.

nihal467 avatar Apr 08 '24 20:04 nihal467

@nihal467 all the cypress test passed

hrit2773 avatar Apr 12 '24 11:04 hrit2773

@hrit2773 image

  • [ ] when a user click the option "asymptomatic", it should auto-close the component, your PR is not preserving the existing behavior in our current staging

nihal467 avatar Apr 18 '24 09:04 nihal467

@nihal467 I see...will fix it

hrit2773 avatar Apr 18 '24 09:04 hrit2773

@nihal467 why are the commas getting excluded during the commit the lint test is failing is it due the changes in prettier? because even if iam adding the commas its considering it as empty commit. @rithviknishad

hrit2773 avatar Apr 21 '24 06:04 hrit2773

Try reinstalling the packages locally. There was a recent version change.

rithviknishad avatar Apr 21 '24 06:04 rithviknishad

@rithviknishad @nihal467 now i added auto close for single select also so it is preserving the previous behaviour of closing the component as soon as user clicks on Asymptomatic.

hrit2773 avatar Apr 21 '24 06:04 hrit2773

@hrit2773 Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar Apr 24 '24 11:04 github-actions[bot]