care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

[Enhancement] Ventilator Parameters Input - Validate Consultation Bed for Linked Ventilator Asset is resolved

Open manasvi-gaur opened this issue 10 months ago • 9 comments

  • Fixes #7397 Issue solved

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

manasvi-gaur avatar Apr 02 '24 03:04 manasvi-gaur

@manasvi-gaur is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 02 '24 03:04 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 48683cfa53be273f7260f7489768292bd18e0505
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66557f313dbafd0008e84a35
Deploy Preview https://deploy-preview-7522--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 02 '24 03:04 netlify[bot]

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar Apr 15 '24 04:04 github-actions[bot]

@rithviknishad I have made relevant changes, kindly review the PR

manasvi-gaur avatar Apr 18 '24 15:04 manasvi-gaur

image image

@manasvi-gaur The issue remains unresolved; the validation check isn't functioning properly. I created a ventilator-related parameter input for a patient without a ventilator asset linked to their bed, yet no notification was triggered.

nihal467 avatar Apr 24 '24 14:04 nihal467

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar May 06 '24 04:05 github-actions[bot]

@nihal467 @rithviknishad, but in my setup its working perfectly without an asset, we can't create a log of critical type with ventilator parameter its showing alert window with functionality to add assets

image

here its notifying to add assets before proceeding while adding ventilator parameter image

manasvi-gaur avatar May 11 '24 14:05 manasvi-gaur

@manasvi-gaur I was able to replicate the issue.

If we submit by editing only the following fields shown in the screenshot, we are able to submit the form without linking a ventilator.

It does works only for changes in fields under the Respiratory Support subtitle.

image

cc: @nihal467

rithviknishad avatar May 13 '24 04:05 rithviknishad

@nihal467 @rithviknishad done, I have made all relevant changes but for that single condition that was failing, due to my examination I was unable to fix that earlier, sorry for inconvenience

manasvi-gaur avatar May 15 '24 09:05 manasvi-gaur

LGTM

nihal467 avatar May 28 '24 06:05 nihal467

@manasvi-gaur Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar May 28 '24 11:05 github-actions[bot]