care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Number of Users under each facility

Open NNSiri opened this issue 10 months ago • 3 comments

The users are mixed up when viewed On viewing View users feature, we are randomly seeing all the users mixed up for each facility.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Facilities - Eg Gokak '

  2. Click on 'manage Facility'

  3. Scroll down to 'View Users'

  4. See error - 39 users are shown

  5. Go to 'Users'

  6. Click on 'Advance filters'

  7. Scroll down to 'State: Karntaka, District : Belagavi '

  8. See error: We see 11 Users for Gokak.

Expected behavior Under (View Facility - Manage Facility - view users) we have to see only the users linked to that particular facility as home facility.

Screenshots When Belagavi district is viewed

WhatsApp Image 2024-04-01 at 14 25 23_28fc8fa2

When Gokak facility is viewed separately **Deskt WhatsApp Image 2024-04-01 at 14 24 10_4508456b

op (please complete the following information):**

  • Browser [e.g. chrome, ]

NNSiri avatar Apr 01 '24 09:04 NNSiri

@rithviknishad @NNSiri can you assign this to me

hrit2773 avatar Apr 01 '24 12:04 hrit2773

@NNSiri @rithviknishad this issue should be solved from the backend side by adding extra filter field to filter it according to the home facility. This would be a better approach can you assign this to me I will make a PR and if possible you can move this issue to the care backend and assign me

hrit2773 avatar Apr 01 '24 18:04 hrit2773

I can make part by part PR one in frontend and other in backend. Can you plz assign me so that I can start working

hrit2773 avatar Apr 02 '24 03:04 hrit2773

@rithviknishad can I take this up?

hrit2773 avatar Apr 14 '24 11:04 hrit2773

Any update on this issue ?

NNSiri avatar Apr 16 '24 12:04 NNSiri

@NNSiri I'm ready to take this up I have had a look on this issue last week. there is no filter for the users based on home facility field that needs to be added it's a frontend and backend issue waiting for a confirmation from @rithviknishad

hrit2773 avatar Apr 16 '24 12:04 hrit2773

@hrit2773 We could develop a better UX to explicitly convey to the users what is being shown, whether the listed users belong to home or linked facilities. One could interpret it differently if not mentioned.

rithviknishad avatar Apr 16 '24 13:04 rithviknishad

@rithviknishad let's give an option to choose whether to show all the users associated with that facility or just with home facility.. how would that be?

hrit2773 avatar Apr 16 '24 13:04 hrit2773

Works, maybe a checkbox saying "include linked facilities"

rithviknishad avatar Apr 16 '24 13:04 rithviknishad

@rithviknishad yes so the tasks to do would be

  1. adding a checkbox to select whether to filter based on home facility or linked facility
  2. adding a filter for home facility
  3. writing test cases

hrit2773 avatar Apr 16 '24 13:04 hrit2773

https://github.com/coronasafe/care_fe/pull/7685 the issue is resolved

nihal467 avatar Apr 27 '24 07:04 nihal467