care_fe
care_fe copied to clipboard
coronasafe
Restrict Unauthorized Users from Accessing Facility's Patient Registration
Proposed Changes
- Fixes #7244
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.
- [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
- [ ] Request for Peer Reviews
- [ ] Completion of QA
@AshrafMd-1 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for care-egov-staging ready!
| Name | Link |
|---|---|
| Latest commit | 5c9682fbedbb95a6895824345cf04027cea7f0bd |
| Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/664252de9463130008bb8907 |
| Deploy Preview | https://deploy-preview-7498--care-egov-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
:wave: Hi, @AshrafMd-1, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for care-net failed.
| Name | Link |
|---|---|
| Latest commit | 1bd1c435abe5f833e5a98eec11aeb8a025da6c2d |
| Latest deploy log | https://app.netlify.com/sites/care-net/deploys/660c1b3225580100082f0716 |
:wave: Hi, @AshrafMd-1, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
test set for restriction
- [x] district admin state admin and home nurse are able to create a patient
- [x] linked doctors and non-home nurse are not able to create a patient
- [x] verify linked doctors are able to view patient datas
- [ ] When I go to a patient details page under my linked facility and click on the patient detail button, I am redirected to a "page not found" page.
- [ ] Similarly, if I go to the patient advanced filters, apply the facility filter for my linked facility, then click the "add patient" button, I am redirected to a "page not found" page.
Expected behavior
@AshrafMd-1 when they try to access them, keep them on the same page, and show the error " Oops! Non-Home facility users don't have permission to perform this action."
CC: @rithviknishad @Ashesh3
@nihal467 @rithviknishad can you check once if it is okay or are there any shortcomings?
@AshrafMd-1
- [ ] When we click on the add patient button with a nurse user having 1 home facility and multiple linked facility, the error is thrown.
Note: Before marking it again for testing, do a QA test for self-evaluation of the PR
CC: @AshrafMd-1
@nihal467 my bad i did check all those edge cases but forgot to test main case
My exams will be over by tomorrow so by the end of Saturday I will submit a tested pr
@AshrafMd-1 Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: