care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

"Solved facility linking issue under manage facilities/view users"#7474

Open Sulochan-khadka opened this issue 10 months ago • 6 comments

Proposed Changes

  • Fixes #7474
  • Added linked facilities slider modal

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

Sulochan-khadka avatar Mar 29 '24 11:03 Sulochan-khadka

@Sulochan-khadka is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 29 '24 11:03 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit c8c38d8f6bb3fb813c62c3933947d71108278599
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66069f9a52af6f0008604249
Deploy Preview https://deploy-preview-7494--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 29 '24 11:03 netlify[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 68efb17c8e66c7cfe14028245b1f5e8a859a69e6
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/661e1d6bd56de90008730528
Deploy Preview https://deploy-preview-7494--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 29 '24 11:03 netlify[bot]

please assign me this issue as i am willing to work on this.

mridulsaggi avatar Mar 30 '24 09:03 mridulsaggi

please assign me this issue as i am willing to work on this.

Hey mate, sadly this is a PR and not an issue, therefore if you want to solve an issue, kindly explore the issue tab.

Sulochan-khadka avatar Mar 30 '24 10:03 Sulochan-khadka

:wave: Hi, @Sulochan-khadka, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Apr 02 '24 13:04 github-actions[bot]

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar Apr 10 '24 04:04 github-actions[bot]

@rithviknishad let me know the way out for this PR to get merged. Thankyou

Sulochan-khadka avatar Apr 11 '24 07:04 Sulochan-khadka

@rithviknishad let me know the way out for this PR to get merged. Thankyou

Could you resolve the merge conflicts?

rithviknishad avatar Apr 13 '24 03:04 rithviknishad

@rithviknishad let me know the way out for this PR to get merged. Thankyou

Could you resolve the merge conflicts?

I will do it right away...

Sulochan-khadka avatar Apr 13 '24 07:04 Sulochan-khadka

@rithviknishad let me know the way out for this PR to get merged. Thankyou

Could you resolve the merge conflicts?

Done...

Sulochan-khadka avatar Apr 13 '24 08:04 Sulochan-khadka

Deploy Preview for care-net failed.

Name Link
Latest commit 03a0b7d475dcb036dd9632b3d38d29c77691814c
Latest deploy log https://app.netlify.com/sites/care-net/deploys/661d6dc09acc18000876c1c3

netlify[bot] avatar Apr 13 '24 08:04 netlify[bot]

@rithviknishad , I also solved a minor error that was causing the deployment to fail. You may have a look.

Sulochan-khadka avatar Apr 13 '24 09:04 Sulochan-khadka

@Sulochan-khadka make the necessary changes

nihal467 avatar Apr 15 '24 16:04 nihal467

@nihal467 @khavinshankar have fixed almost all lint errors... Well I did not find one lint error the workflow was indicating at... replacing ... with '....' , when there is no such statement . Do let me know immediately if unknowingly I messed up something. Also have just commented out showFacilites since it might be of use in future.

Sulochan-khadka avatar Apr 15 '24 18:04 Sulochan-khadka

LGTM

nihal467 avatar Apr 16 '24 06:04 nihal467

@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands:

github-actions[bot] avatar Apr 16 '24 07:04 github-actions[bot]