care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Solved issue "Enhancement to MEWS Score"

Open r-nikhilkumar opened this issue 11 months ago • 18 comments

  • Fixes #7373
  • Allow calculation of MEWS score by fetching the relevant 5 data points spread across multiple log updates filed within a time frame of 30 min✅
  • Add measured at time under the MEWS on Patient dashboard. mention the time stamp of the latest of the 5-parameters✅

depends on https://github.com/coronasafe/care/pull/1991

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

r-nikhilkumar avatar Mar 19 '24 13:03 r-nikhilkumar

@r-nikhilkumar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 19 '24 13:03 vercel[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 240ae1a3ad7cc715afece593c8a64bf7cbd8b6d0
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/662a9ac9230be400081e0985
Deploy Preview https://deploy-preview-7438--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 19 '24 13:03 netlify[bot]

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar Mar 28 '24 04:03 github-actions[bot]

@rithviknishad, please remove stale label

r-nikhilkumar avatar Mar 28 '24 05:03 r-nikhilkumar

Deploy Preview for care-net failed.

Name Link
Latest commit 55754ad9a84e2c4f1e484863c726e71e3a90ce52
Latest deploy log https://app.netlify.com/sites/care-net/deploys/660c2a6e2dca0400088647bf

netlify[bot] avatar Apr 02 '24 15:04 netlify[bot]

@r-nikhilkumar image

the deploy build is failing fix it

nihal467 avatar Apr 02 '24 16:04 nihal467

@nihal467 first need to merge the backend then the test will be passed

r-nikhilkumar avatar Apr 03 '24 02:04 r-nikhilkumar

@r-nikhilkumar ig the problem is with the typescript errors , see the screenshot attached

rash-27 avatar Apr 03 '24 02:04 rash-27

@rash-27 yeah, sorry I didn't see ss

r-nikhilkumar avatar Apr 03 '24 03:04 r-nikhilkumar

@r-nikhilkumar We've recently introduced type-checks at the build step to voluntarily fail the build if there were type errors. This was done to improve code quality and catch potential bugs early on before it even gets merged. Ref: https://github.com/coronasafe/care_fe/pull/7469

It'd be appreciated if you could fix the type errors introduced in this PR.

rithviknishad avatar Apr 03 '24 03:04 rithviknishad

@nihal467 solved the typeError now you can test it, sorry for inconvenience

r-nikhilkumar avatar Apr 03 '24 03:04 r-nikhilkumar

so for that I need to make changes in consultationModel interface and I also need to create an interface for mewFields with all the required attribute, could I make changes in model interface?

r-nikhilkumar avatar Apr 03 '24 06:04 r-nikhilkumar

image

Above is PR deployment

image

Above is the current staging

@r-nikhilkumar When there is a log update present for a patient, and the MEWS relevant data are missing, the MEWS score should be displayed as "-" Upon hovering over it, the related tooltip should show the missing data and related information. This functionality is currently working properly in the staging environment but is missing in your pull request.

It is a basic functionality of the MEWS score. Therefore, I kindly request you to familiarize yourself with the function first, understand its functionality, make the necessary changes, conduct self QA of the function, and then submit it for review.

nihal467 avatar Apr 08 '24 11:04 nihal467

@nihal467 it is because I made this change image

in my local its showing the mews field as you shown in staging view, it is not showing in deployed preview might be a reason that from backend mews_field is not getting sent as a response field and to get mews_field in response first need to make changes from backend and for the backend changes i raised a pr https://github.com/coronasafe/care/pull/1991 already once that will be deployed in main server, then the mews_field response will be fetched successfully and the mews score will be shown too image

r-nikhilkumar avatar Apr 08 '24 13:04 r-nikhilkumar

:wave: Hi, @r-nikhilkumar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Apr 15 '24 17:04 github-actions[bot]

discussion is going on in the backend repo : https://github.com/coronasafe/care/pull/1991

nihal467 avatar Apr 16 '24 13:04 nihal467

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar Apr 24 '24 04:04 github-actions[bot]

:wave: Hi, @r-nikhilkumar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar May 07 '24 09:05 github-actions[bot]

@r-nikhilkumar closing this PR and unassigning you from this issue due to inactivity, feel free to reopen the same if you are still working on it

nihal467 avatar May 14 '24 09:05 nihal467

@nihal467 is the issue still in progress and not resolved, why you reopened this my PR?🤔

r-nikhilkumar avatar Aug 19 '24 05:08 r-nikhilkumar

@r-nikhilkumar https://github.com/ohcnetwork/care_fe/issues/7373#issuecomment-2296147719 , can you post a reply to this message

nihal467 avatar Sep 06 '24 15:09 nihal467