care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Preset save- need to refresh's

Open aparnacoronasafe opened this issue 11 months ago • 24 comments

Is your feature request related to a problem? Please describe. Users have the option to save a change made to the preset position right on patient dashboard- live feed. However such update to the preset is only available when the user refreshes the page.

Describe the solution you'd like When a user updates preset- such updation must be available immediately. The user must not have to refresh the page to access the updated preset.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

aparnacoronasafe avatar Mar 05 '24 13:03 aparnacoronasafe

Hi, I would like to work on this issue, can you please assign it to me?

KshitijTodkar48 avatar Mar 05 '24 13:03 KshitijTodkar48

@aparnacoronasafe, how can I get the live feed while developing and testing locally and with what role, can I reach the live feed section?

KshitijTodkar48 avatar Mar 07 '24 13:03 KshitijTodkar48

@rithviknishad, @aparnacoronasafe can you please answer my query?

KshitijTodkar48 avatar Mar 09 '24 15:03 KshitijTodkar48

You can use the asset "Dev Camera" for testing. It is linked to patient:

https://care.ohc.network/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/feed

rithviknishad avatar Mar 10 '24 03:03 rithviknishad

@rithviknishad, I have found the files to make changes in the codebase. But to test the changes, I checked the assets, no asset had live camera feeds working. And could not find the asset with the name "Dev Camera". And the link you shared is showing "Page not found". Am I missing something here?

KshitijTodkar48 avatar Mar 14 '24 08:03 KshitijTodkar48

@rithviknishad, I have found the files to make changes in the codebase. But to test the changes, I checked the assets, no asset had live camera feeds working. And could not find the asset with the name "Dev Camera". And the link you shared is showing "Page not found". Am I missing something here?

Try Logging in using "devdistrictadmin" as username and "Coronasafe@123" as password

thedevildude avatar Mar 14 '24 10:03 thedevildude

@rithviknishad , @thedevildude, I logged in as "devdistrictadmin" as you said and reached the camera feed. But the feed is offline. Also, when I start the project locally, there are no patients that have camera feed available and working.

KshitijTodkar48 avatar Mar 14 '24 12:03 KshitijTodkar48

As long as you connect your frontend to staging backend, you should be able to access the patient with the dev camera.

Dev Camera could be offline at times. cc: @nihal467 @gigincg

rithviknishad avatar Mar 16 '24 09:03 rithviknishad

@rithviknishad, I have the backend running locally, how to connect my local frontend to the backend, because I still cannot see the "Dev Camera" asset and the live feed, what else should I do?

KshitijTodkar48 avatar Mar 17 '24 16:03 KshitijTodkar48

Check now with the above-mentioned credentials. I've updated the configurations

https://care.ohc.network/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/assets/fd605386-90d5-4e8b-bb82-f62b7349d1d3/configure

rithviknishad avatar Mar 18 '24 12:03 rithviknishad

@rithviknishad, Thanks for your help so far. I've checked the live-feed, it is working. I tried updating the preset values of the live-feed and the updates were immediately available without the need of refreshing the page. I didn't find the described issue. The updated presets are available immediately without the need of refreshing the page.

KshitijTodkar48 avatar Mar 18 '24 18:03 KshitijTodkar48

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

github-actions[bot] avatar Apr 02 '24 04:04 github-actions[bot]

I'd like to work on this issue if it's still relevant

thedevildude avatar Apr 02 '24 12:04 thedevildude

Go ahead man, I'm not working on it.

KshitijTodkar48 avatar Apr 02 '24 13:04 KshitijTodkar48

@thedevildude could you confirm if the issue is still relevant? After updating a preset - does it reflect immediately or you need to manually refresh the page?

Ashesh3 avatar Apr 03 '24 06:04 Ashesh3

@Ashesh3 it does seem to work fine in my case. After updating a preset, I switched to a different preset, and then switched back to the updated preset, the updated preset was as expected without refreshing the page.

thedevildude avatar Apr 03 '24 08:04 thedevildude

@aparnacoronasafe could you confirm the same, so we can close the issue?

cc: @nihal467

Ashesh3 avatar Apr 03 '24 09:04 Ashesh3

Even I didn't find the described issue @Ashesh3, I've mentioned it earlier as well.

KshitijTodkar48 avatar Apr 03 '24 13:04 KshitijTodkar48

I'm able to replicate the issue, it's pretty straightforward as mentioned in the issue.

rithviknishad avatar Apr 04 '24 03:04 rithviknishad

See the attached video, where I try to correct the preset: "Clock" to where the clock is visible. Had to refresh for the preset buttons to know about the new coordinates.

https://www.loom.com/share/44a11f82b1e34c6c8a58116ae1a9fc48?sid=c61559a6-084d-4abd-aeb4-5ca51b7f50b7

rithviknishad avatar Apr 04 '24 03:04 rithviknishad

@rithviknishad @Ashesh3 When using devdistrictadmin on staging deployment, the default presets doesn't update for some reason. When we refresh the page, the last location of camera is available however on selecting the same default preset again, we are sent back to old position. The patient presets seems to work fine. Is it supposed to happen?

https://github.com/coronasafe/care_fe/assets/63492939/af4d8ffc-1287-4c41-ba04-0f10de3c8c5a

thedevildude avatar Apr 04 '24 07:04 thedevildude

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

github-actions[bot] avatar Apr 19 '24 04:04 github-actions[bot]

I've started working on it, should be ready with a draft PR by Monday

thedevildude avatar Apr 21 '24 05:04 thedevildude

@thedevildude Unassigning you from this issue due to inactivity. Feel free to reassign yourself if you are still working on it.

nihal467 avatar Apr 27 '24 07:04 nihal467