care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Redesign the header to be consistent across all pages

Open sainak opened this issue 11 months ago • 25 comments

Currently the header is very inconsistent and space consuming on the screen so, to fix that make the header a reusable component

current headers across pages image image image image image image image image image

very rough sketch:

image

cc: @aparnacoronasafe

sainak avatar Feb 29 '24 16:02 sainak

@sainak @rithviknishad can you please assign this issue to me

saloni0419 avatar Feb 29 '24 16:02 saloni0419

@saloni0419 wait for a thumbs up from @aparnacoronasafe

sainak avatar Feb 29 '24 16:02 sainak

Sure

saloni0419 avatar Feb 29 '24 16:02 saloni0419

I would like to work on this issue. I will focus on making the header a separate component. In order to make the header reusable I would like to use the concept of barrel export with the header component. If you kindly allow me to work on this issue @sainak @aparnacoronasafe @rithviknishad

ab1123 avatar Feb 29 '24 18:02 ab1123

Hi, @sainak can I work on the issue, I would create a new general header component that would fit most of the types shown, for any extra case we can create a separate functional component in the same component file

SinghYuvraj0506 avatar Mar 01 '24 14:03 SinghYuvraj0506

@sainak @aparnacoronasafe any updates on this issue??

ab1123 avatar Mar 01 '24 23:03 ab1123

Hii @sainak can i work on this issue.

kumar11jr avatar Mar 02 '24 04:03 kumar11jr

I would like to work on this , can you please assign me

UdaySagar-Git avatar Mar 02 '24 16:03 UdaySagar-Git

Please go ahead.

However, the suggested design is missing some elements. like the "Live / Discharge" tabs.

Please be mindful of retaining all the elements in the headers

aparnacoronasafe avatar Mar 06 '24 14:03 aparnacoronasafe

@saloni0419 @ab1123 @SinghYuvraj0506 @kumar11jr @UdaySagar-Git Post your mockups and implementation plan before working on this issue

cc: @Ashesh3 @rithviknishad @nihal467

sainak avatar Mar 06 '24 15:03 sainak

Hii @sainak can i work on this issue.

Shahbaz898414 avatar Mar 06 '24 21:03 Shahbaz898414

hi @sainak can i work on this issue? my implementation plan will be :

-i will make a reusable component named Header in a Common/components/ directory named Header.js file -and another component named HeaderCountBlock in CAREUI/display/Count.js directory for no of counts of each sections like results sample like this image -for the header section each component like searchbox , advanced filter , switch tabs will be sent as a props and will render

and the final result may look like this image image image will be changed according to your suggestions!!

bishwas-10 avatar Mar 07 '24 14:03 bishwas-10

Hii @sainak , I would like to work on this , can you please assign me

yashdargude avatar Mar 07 '24 15:03 yashdargude

hi @sainak can i work on this issue? my implementation plan will be :

-i will make a reusable component named Header in a Common/components/ directory named Header.js file -and another component named HeaderCountBlock in CAREUI/display/Count.js directory for no of counts of each sections like results sample like this image -for the header section each component like searchbox , advanced filter , switch tabs will be sent as a props and will render

and the final result may look like this image image image will be changed according to your suggestions!!

@bishwas-10 this still does not look consistent at all across all pages.

The objective is to have consistent placement of common elements like filter buttons should be present in the same location on every page. Same with Import/Export, Add (Patient | Asset | ...), etc.

rithviknishad avatar Mar 07 '24 15:03 rithviknishad

@rithviknishad ok i will work on that as i mentioned above will be changed according to your suggestion. And it will be easy for me to work on this if you guys assign me this issue

bishwas-10 avatar Mar 07 '24 15:03 bishwas-10

@rithviknishad ok i will work on that as i mentioned above will be changed according to your suggestion. And it will be easy for me to work on this if you guys assign me this issue

https://github.com/coronasafe/care_fe/issues/7316#issuecomment-1981128727

rithviknishad avatar Mar 07 '24 15:03 rithviknishad

@sainak @rithviknishad , i have built a mockup considering all the above conditions

Screenshot 2024-03-08 at 1 11 10 AM

From the above images of headers we currently have, I found some points :-

  1. There are some fields which are common on every header like export/import , filters , a search field, section name, counts
  2. Some CTA are present on some headers, these are different for different sections .
  3. Some pages contain some switches for parsing different data.
  4. Some pages contain more than one search fields.

The mockup solves all these problems,:

  1. The fixed fields are kept constant at one corner.
  2. These CTA can be added according to our needs and are optional, can handle more buttons too in a grid system
  3. We can fix a switch on the topmost side of the header which is optional
  4. I have provided a dropdown in the search field, where one can select the search prop to be searched and add more such search fields.

in technical aspect Let's create a header component capable of all these features, it would have props that would control all these features like:

image

cc: @nihal467 @Ashesh3

SinghYuvraj0506 avatar Mar 07 '24 19:03 SinghYuvraj0506

@SinghYuvraj0506 This looks great and example code seems to be very reusable and would lead to a consistent design pattern.

Just letting you know that, we generally refrain from "Icon Only" designs. It'd be great if labels are also present along with the icons so any users who may not be able to interpret icons would also find it easy to use.

rithviknishad avatar Mar 08 '24 05:03 rithviknishad

@rithviknishad i would use labels instead of icons, or we could even use the tip to tell about the tool over hovering it. Also we need a responsive mobile UI , I think it would be best if we could align all the features of top row of the design I provided into hamburger menu and rest could be adjusted

SinghYuvraj0506 avatar Mar 14 '24 12:03 SinghYuvraj0506

But we already have a hamburger menu for mobile. Did you mean to have two hamburger menus?

rithviknishad avatar Mar 14 '24 16:03 rithviknishad

Hii @sainak , I would like to work on this , can you please assign me

Shahbaz898414 avatar Mar 14 '24 17:03 Shahbaz898414

I have made all the possibilities of the header in the design

Screenshot 2024-03-15 at 5 00 08 PM

Hey @rithviknishad @sainak @nihal467 look into the design and if it is correct , then I would to like to work on the issue, could you please assign it to me

SinghYuvraj0506 avatar Mar 15 '24 11:03 SinghYuvraj0506

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

github-actions[bot] avatar Mar 30 '24 04:03 github-actions[bot]