care_fe
care_fe copied to clipboard
Added Timeline UI for Bed Activity
Proposed Changes
- Fixes #6771
- Integrated Timeline for Bed Activity using BedActivityTimeline
What's Changed?
Before:
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.
- [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
- [ ] Request for Peer Reviews
- [ ] Completion of QA
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
care-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 12, 2024 1:56pm |
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | b4afe2885b0c3f237741ef2f489582a08942db02 |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/6628a1823615d9000892a769 |
Deploy Preview | https://deploy-preview-6901--care-egov-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
We are currently showing time in two places which is redundant.
Also can we improve the wording to something like this instead (just suggesting, feel free to add your creativity)
- Transferred to <b>{bed_name} in {location_name}</b> (relative time) - Transferred to <b>{bed_name} in {location_name}</b> (relative time) - Occupied <b>{bed_name} in {location_name}</b> (relative time)
I'll be working on some mockups and share them on channel
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.
@thedevildude make the following changes to the PR:
-
[x] move all the input field's to one row
-
[ ] change the in use badge to similar design as of no consultation badge and primary colour
-
[ ] move relative time (created at) into a pop-over of (i) icon , and replace the relative time with (i) icon in the design
-
[ ] modify the asset linked text to explicitly mention the asset is linking or unlinking in a bed and dont have a explicit heading called linked assets
-
[ ] have explicit icons for asset link (need to add) , asset unlinking (need to add) and bed assigned(already exist in your PR)
@aparnacoronasafe Looking for your input on the current Timeline UI for Bed activity. As we are not tracking asset changes on the backend, I have implemented manual checks on the frontend to determine which assets have changed. I've segregated the assets into three categories for each Timeline Node namely, Newly Linked Assets (assets linked in that node), Existing Assets (carry over from previous object) and Unlinked Assets (assets that were unlinked in that node.
@thedevildude is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.
A member of the Team first needs to authorize it.
@thedevildude
- [ ] In one of the EOD calls, we decided to keep each field in its separate rows, you forgot to implement it
- [ ] along with that, we decided one more thing that is the icon of the present bed should be green for the current bed
Also, can we have a divider between the form and the timeline?
And maybe move the move to bed button to the right?
@thedevildude
hide the "No asset linked" , only show details about asset, if anything is linked
:wave: Hi, @thedevildude, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
Deploy Preview for care-net failed.
Name | Link |
---|---|
Latest commit | 109ba669d52fc08f8127d5ee0fdcc4fc52719e40 |
Latest deploy log | https://app.netlify.com/sites/care-net/deploys/660e88420fcd370008e13bbb |
@thedevildude fix the lint
@nihal467 not sure if the Lint workflow is providing correct results. Locally the said files doesn't have any linting errors.
try re-installing the packages in your local. Recently the version has changed and seems to be causing similar issues for couple of contributors. Upgrading locally fixes it
LGTM
@thedevildude Your efforts have helped advance digital healthcare and TeleICU systems. :rocket: Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! :raised_hands: