care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Show more monitors in CNS on very large displays

Open rithviknishad opened this issue 1 year ago • 9 comments

Describe the bug When CNS is opened in large 4K displays, 75% of the screen space is wasted.

To Reproduce Steps to reproduce the behavior:

  1. Visit https://deploy-preview-6396--care-net.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/cns on a 4K display

Expected behavior On large displays, render more vitals monitors into view per page.

Screenshots

image

rithviknishad avatar Oct 26 '23 14:10 rithviknishad

9 monitors if available should be fine in this size screen i guess or maybe increase the size of monitors to use most of screen with same no. as it is

I would like to work on it.

kshitijv256 avatar Oct 28 '23 08:10 kshitijv256

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

github-actions[bot] avatar Nov 12 '23 04:11 github-actions[bot]

I can pick this up if still required

ayush-seth avatar Nov 17 '23 16:11 ayush-seth

hey @nihal467 I would like to work on this can you assign this to me

MjStar24 avatar Mar 16 '24 19:03 MjStar24

hey @rithviknishad when I am clicking on the above it is showing no data found

Screenshot 2024-03-18 173337

MjStar24 avatar Mar 18 '24 12:03 MjStar24

Try logging in as devdistrictadmin Coronasafe@123 instead.

rithviknishad avatar Mar 18 '24 12:03 rithviknishad

thanks @rithviknishad its working!

MjStar24 avatar Mar 18 '24 12:03 MjStar24

hey @rithviknishad I have raised the pull request for this issue

what I have done :

-by default 6 monitors will displayed per view page for small screens -for large screens 9 monitors will be displayed per view page for 4k displays -for this I have used window.resize and react hooks to check the display size and change number of monitors according to display size

MjStar24 avatar Mar 19 '24 16:03 MjStar24

@MjStar24 Unassigning you from this issue due to inactivity. Feel free to reassign yourself if you are still working on it.

nihal467 avatar Apr 27 '24 07:04 nihal467