care_fe
care_fe copied to clipboard
Redesigned Facility Home Page
fixes #3757
Proposed Changes
- Redesigned Facility Home Page
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.
- [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
- [ ] Request for Peer Reviews
- [ ] Completion of QA
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | 51ac8b9b77e62298f6241f159a276d45f1cffb7b |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/637629b6723509000965a5aa |
Deploy Preview | https://deploy-preview-3819--care-egov-staging.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
:wave: Hi, @GokulramGHV, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
care-storybook | ✅ Ready (Inspect) | Visit Preview | Nov 17, 2022 at 0:33AM (UTC) |
@GokulramGHV
- [ ] triage is not responsive in mobile view
- [ ] in the oxygen table is not responsive
@nihal467 I've made the changes that you had mentioned
@GokulramGHV
- [ ] triage is not responsive in mobile view
- [ ] in the oxygen table is not responsive
@GokulramGHV I meant for the DropdownItem, not the menu button 😅.
Oh sorry my bad 😅
Deploy Preview for care-net failed.
Name | Link |
---|---|
Latest commit | 3ee10d953b4cfc1471cdd705b12da9c3cdc9a91a |
Latest deploy log | https://app.netlify.com/sites/care-net/deploys/6368b8e59cf7000009c8709e |
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells
No Coverage information
0.0% Duplication
New changes made
- Improve how ButtonV2 and DropdownMenuItem authorization works
- Unauthorized actions are hidden in dropdown menu:
@GokulramGHV see a comment by rithvik, once completed, change it to need testing
@GokulramGHV see a comment by rithvik, once completed, change it to need testing
@nihal467 I've made all the changes that rithvik suggested. The PR is ready for testing.
@GokulramGHV after the comments, i can't see any pushes to the PR, are you sure, all the changes are been merged to the PR
@nihal467 the last comment by me was just about the changes that I have pushed. Not a request for changes to be made. It's ready for testing
@GokulramGHV the PR looks good to me. Marking it as team discussion required for the final approval of the PR
Below suggestion only to be worked after todays discussion if got approved
the number highlighted in blue, doesn't look good, is there any other better alternative for it
@GokulramGHV use the default blue colour for the phone number
@nihal467 @aparnacoronasafe @rithviknishad Is this color okay for the phone no.?
This looks fine I feel. Can you also add tracking-widest
or tracking-wider
class to the phone number? Phone numbers would be easier to read.
Also lets wrap that to a component ContactLink
which has props:
type ContactLinkProps =
| { mailto: string; tel: undefined }
| { mailto: undefined; tel: string };
This way we can re-use the component with a consistent design everywhere in future.
:wave: Hi, @GokulramGHV, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@GokulramGHV PR looks good to me. Marking it as "Team discussion required" for final approval
:wave: Hi, @GokulramGHV, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
PR final design approved, @khavinshankar it is good to merge
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells
No Coverage information
0.0% Duplication