care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Redesigned Facility Home Page

Open GokulramGHV opened this issue 2 years ago • 2 comments

fixes #3757

Proposed Changes

  • Redesigned Facility Home Page

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

GokulramGHV avatar Oct 24 '22 12:10 GokulramGHV

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 51ac8b9b77e62298f6241f159a276d45f1cffb7b
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/637629b6723509000965a5aa
Deploy Preview https://deploy-preview-3819--care-egov-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 24 '22 12:10 netlify[bot]

:wave: Hi, @GokulramGHV, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Oct 26 '22 06:10 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 0:33AM (UTC)

vercel[bot] avatar Oct 27 '22 09:10 vercel[bot]

@GokulramGHV image

  • [ ] triage is not responsive in mobile view

image

  • [ ] in the oxygen table is not responsive

nihal467 avatar Nov 02 '22 09:11 nihal467

@nihal467 I've made the changes that you had mentioned

@GokulramGHV image

  • [ ] triage is not responsive in mobile view

image

  • [ ] in the oxygen table is not responsive

GokulramGHV avatar Nov 05 '22 08:11 GokulramGHV

@GokulramGHV I meant for the DropdownItem, not the menu button 😅. image

Oh sorry my bad 😅

GokulramGHV avatar Nov 05 '22 17:11 GokulramGHV

Deploy Preview for care-net failed.

Name Link
Latest commit 3ee10d953b4cfc1471cdd705b12da9c3cdc9a91a
Latest deploy log https://app.netlify.com/sites/care-net/deploys/6368b8e59cf7000009c8709e

netlify[bot] avatar Nov 07 '22 07:11 netlify[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 07 '22 08:11 sonarqubecloud[bot]

New changes made

  • Improve how ButtonV2 and DropdownMenuItem authorization works
  • Unauthorized actions are hidden in dropdown menu: image image

rithviknishad avatar Nov 07 '22 08:11 rithviknishad

@GokulramGHV see a comment by rithvik, once completed, change it to need testing

nihal467 avatar Nov 08 '22 12:11 nihal467

@GokulramGHV see a comment by rithvik, once completed, change it to need testing

@nihal467 I've made all the changes that rithvik suggested. The PR is ready for testing.

GokulramGHV avatar Nov 08 '22 12:11 GokulramGHV

@GokulramGHV after the comments, i can't see any pushes to the PR, are you sure, all the changes are been merged to the PR

nihal467 avatar Nov 08 '22 12:11 nihal467

@nihal467 the last comment by me was just about the changes that I have pushed. Not a request for changes to be made. It's ready for testing

rithviknishad avatar Nov 08 '22 12:11 rithviknishad

@GokulramGHV the PR looks good to me. Marking it as team discussion required for the final approval of the PR

Below suggestion only to be worked after todays discussion if got approved

image

the number highlighted in blue, doesn't look good, is there any other better alternative for it

nihal467 avatar Nov 08 '22 12:11 nihal467

@GokulramGHV use the default blue colour for the phone number

nihal467 avatar Nov 08 '22 14:11 nihal467

@nihal467 @aparnacoronasafe @rithviknishad Is this color okay for the phone no.? image

GokulramGHV avatar Nov 09 '22 18:11 GokulramGHV

This looks fine I feel. Can you also add tracking-widest or tracking-wider class to the phone number? Phone numbers would be easier to read.

Also lets wrap that to a component ContactLink which has props:

type ContactLinkProps =
  | { mailto: string; tel: undefined }
  | { mailto: undefined; tel: string };

This way we can re-use the component with a consistent design everywhere in future.

rithviknishad avatar Nov 09 '22 18:11 rithviknishad

:wave: Hi, @GokulramGHV, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Nov 10 '22 11:11 github-actions[bot]

@GokulramGHV PR looks good to me. Marking it as "Team discussion required" for final approval

nihal467 avatar Nov 15 '22 11:11 nihal467

:wave: Hi, @GokulramGHV, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Nov 16 '22 12:11 github-actions[bot]

PR final design approved, @khavinshankar it is good to merge

nihal467 avatar Nov 16 '22 15:11 nihal467

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 17 '22 12:11 sonarqubecloud[bot]