care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Added close and currect location select buttons in GLocationPicker

Open khavinshankar opened this issue 2 years ago • 2 comments

Proposed Changes

  • Added custom custom to close gmap
  • Added custom button to select current location

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

khavinshankar avatar Oct 24 '22 03:10 khavinshankar

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit bedd78fbea3f95eb5f5ccaf46fb5a87027afcb88
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63748bd66f1ea3000817d12a
Deploy Preview https://deploy-preview-3817--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 24 '22 03:10 netlify[bot]

@khavinshankar image

iam getting a something went wrong error in this PR, when gps location is not added

nihal467 avatar Oct 26 '22 08:10 nihal467

@khavinshankar image

  • [x] when we are opening the create facility page, the current location of the system are been auto filed, before even we are clicking the locate icon

image

  • [ ] the search bar is covering the whole map, now, unable to see the map

nihal467 avatar Oct 26 '22 13:10 nihal467

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 7:07AM (UTC)

vercel[bot] avatar Oct 26 '22 13:10 vercel[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 26 '22 13:10 sonarqubecloud[bot]

image

  • [ ] the search bar is covering the whole map, now, unable to see the map

@nihal467 This is working fine in the local, this issue is caused due to permission error, @mathew-alex can you please check this out image

khavinshankar avatar Oct 26 '22 13:10 khavinshankar

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions[bot] avatar Nov 03 '22 04:11 github-actions[bot]

@khavinshankar, @nihal467 - permissions updated Screenshot 2022-11-09 at 10 31 58 PM

mathew-alex avatar Nov 09 '22 17:11 mathew-alex

@khavinshankar image

  • [x] Currently, there is no way to get to our current location,

image

  • [x] add something like the current location icon in the map, so that the user can click on it to track the current location

image

  • [x] when we click on the button, our location details are not getting auto-filled in the longitude and latitude column

nihal467 avatar Nov 10 '22 08:11 nihal467

@nihal467 the icon on the top left is used to get the current location image

khavinshankar avatar Nov 10 '22 08:11 khavinshankar

@khavinshankar the button is not working

nihal467 avatar Nov 11 '22 12:11 nihal467

@khavinshankar the button is not working

@nihal467 can you try it in incognito, it seems to be working fine

khavinshankar avatar Nov 11 '22 12:11 khavinshankar

Also Fixes #1095

Pranshu1902 avatar Nov 11 '22 13:11 Pranshu1902

@khavinshankar image

can you take care of the responsive issue

nihal467 avatar Nov 15 '22 11:11 nihal467

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 16 '22 07:11 sonarqubecloud[bot]

test approved

nihal467 avatar Nov 16 '22 07:11 nihal467