care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Fixes Local Body selection in user add not handling change

Open rithviknishad opened this issue 2 years ago • 2 comments

Fixes #3519

Local body selection is now handling change.

image

Proposed Changes

  • invoke the handleChange.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

rithviknishad avatar Sep 02 '22 03:09 rithviknishad

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 9a2535581d0dd5dff0a2020455264fd060e5f753
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6321a0c614c80d000886972d
Deploy Preview https://deploy-preview-3521--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 02 '22 03:09 netlify[bot]

@rithviknishad image

once all the mandatory fields are filled, the local body field got vanished from the form, check the error

nihal467 avatar Sep 07 '22 07:09 nihal467

@nihal467 the local body field is not applicable for the following user types:

image

rithviknishad avatar Sep 07 '22 07:09 rithviknishad

@rithviknishad can you merge the latest development

nihal467 avatar Sep 12 '22 14:09 nihal467

@rithviknishad test approved, but the cypress is failing

nihal467 avatar Sep 14 '22 09:09 nihal467

@nihal467 Tests are failing whats out of the scope of the changes I intended to achieve in this PR. All are timeouts, including the one's in the scope of this PR.

Screenshots

rithviknishad avatar Sep 14 '22 09:09 rithviknishad

@khavinshankar can you have a look on this

nihal467 avatar Sep 14 '22 09:09 nihal467

Probably the staging API is not able to handle it? Since 403 and 502's are being returned.

rithviknishad avatar Sep 14 '22 09:09 rithviknishad

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 14 '22 09:09 sonarqubecloud[bot]