care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Published 20 hours ago • verified publisher icon coronasafe

fix: add loader to external results section

Open Pragati1610 opened this issue 2 years ago • 8 comments

fix #2454

Pragati1610 avatar Aug 24 '22 13:08 Pragati1610

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 5248d55a30247ccdb02e1700e1041db9d2d9d312
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/633a33b36d489300084b93b6
Deploy Preview https://deploy-preview-3467--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 24 '22 13:08 netlify[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 24 '22 13:08 sonarqubecloud[bot]

@Pragati1610 In the External Results section, Total Results shows 0 till the data is fetched from the backend. Can you add a loader instead? (just like there is one for Total Patients in the Patients section)

This is exactly the changes in this PR does. Is there another place?

Pragati1610 avatar Sep 06 '22 14:09 Pragati1610

:wave: Hi, @Pragati1610, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

mathew-alex avatar Sep 27 '22 10:09 mathew-alex

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 03 '22 00:10 sonarqubecloud[bot]

There is a github test Auto Label Conflicts / auto-label (pull_request) is failing

Is this change mentioned in this article required: resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac

Pragati1610 avatar Oct 03 '22 01:10 Pragati1610

Hi, This pr/issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

stale[bot] avatar Oct 12 '22 04:10 stale[bot]

Wouldn't this show the loading component even when the external results list from the backend is empty?

There is no other way to know about it otherwise

If it is empty, it will show the loader and then show that no results found.

Technically a loader is to wait for results irrespective of what is in the results I suppose, so ig it shouldn't be a problem though if you have any ideas on making this better in user experience do share.

Pragati1610 avatar Oct 20 '22 12:10 Pragati1610

@Pragati1610 this doesn't seem relevant anymore, if the issue persists, feel free to reopen it or create a new pr

khavinshankar avatar Jan 09 '23 14:01 khavinshankar