care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Published 20 hours ago • verified publisher icon coronasafe

Adds fields to Asset model as per asset registration v2

Open rithviknishad opened this issue 2 years ago • 3 comments

Closes #3426 as part of #2212

In the Asset Create/Update and Asset Detail page:

  • [x] Renamed "Phone No" as "Customer support No."
  • [x] The following fields were added in the Asset Create/Update and Asset Detail page

1: Manufacturer: Short text field, optional 2: Warranty/AMC applicable till: Date, Optional 3: Last serviced on: Date- Optional 4: Notes: Long text field- optional

  • [x] Field warranty_details removed from the Asset Create/Update and Asset Detail

rithviknishad avatar Aug 22 '22 18:08 rithviknishad

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 5d4c43af0918dfdc15a4aa8b18c67dc2e8e1d68a
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6332dfed06817800081b62bf
Deploy Preview https://deploy-preview-3458--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 22 '22 18:08 netlify[bot]

@rithviknishad

merge the latest development branch,

image

UI is breaking everywhere

nihal467 avatar Sep 07 '22 07:09 nihal467

@rithviknishad merge the latest development branch

nihal467 avatar Sep 07 '22 13:09 nihal467

@rithviknishad merge the latest development branch

nihal467 avatar Sep 12 '22 14:09 nihal467

@rithviknishad

image

  • [ ] in the responsive view, all the buttons and fields are in multiple length

image

  • [ ] rather than having the card vertical, shall we keep it horizontal, shall we discuss about it in the EOD before working on this

nihal467 avatar Sep 14 '22 09:09 nihal467

:wave: Hi, @rithviknishad, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

mathew-alex avatar Sep 27 '22 10:09 mathew-alex

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.4% 0.4% Duplication

sonarqubecloud[bot] avatar Sep 27 '22 11:09 sonarqubecloud[bot]

@rithviknishad In the weekly call, we discussed about the two scroller been coming out in the asset creation page, are you working on it now or will it be a another PR coming after this one is merged !

nihal467 avatar Sep 28 '22 03:09 nihal467

@nihal467 I'll make it as another PR then, since this PR has lot's of changes, its getting merge conflicts pretty quickly.

rithviknishad avatar Sep 28 '22 03:09 rithviknishad

@rithviknishad image

i feel like the card is little bit towards down, shall we move a bit up, just an opinion, what do you think,

nihal467 avatar Sep 28 '22 04:09 nihal467

@rithviknishad @khavinshankar seem like a small alignment issue, we can work on another PR, this LGTM,

nihal467 avatar Sep 28 '22 04:09 nihal467