care_fe
care_fe copied to clipboard
Revamped Upload files buttons
Fixes #3418 http://localhost:4000/sample/f01568f0-3b58-418a-96fc-89d228073462
Made buttons full width for mobile view
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | b22b7658986cf6c32442006aef27fb7be9441892 |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/635987fe8ba9090009ca26f7 |
Deploy Preview | https://deploy-preview-3419--care-egov-staging.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Updated Browse
button view:
Deploy Preview for care-net failed.
Name | Link |
---|---|
Latest commit | d0f8561a29713d8d302addeb4aaa63c2846e183e |
Latest deploy log | https://app.netlify.com/sites/care-net/deploys/63006ec8a161510009643d18 |
@Pranshu1902 is it good for testing
@Pranshu1902 is it good for testing
Yes
@Pranshu1902 test failed, check the button alignment in normal view
@nihal467
Updated view:
@Pranshu1902
in responsive view, the buttons are not having gap in between them
@nihal467
Updated view:
test approved
@nihal can you please retest this one
@Pranshu1902 LGTM, but merge the latest development and check the cypress test
@nihal467 merged develop branch
@Pranshu1902 test approved, but the cypress is failing, check it
@nihal467 Staging BE can't handle the speed of cypress that's why it is failing
@developedBySJ can you please re-review this pr
@khavinshankar
updated view:
:wave: Hi, @Pranshu1902, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.
@Pranshu1902
- [ ] the buttons are off aligned in normal view and mobile view
- [ ] the buttons are feeling over sized, look into it
@nihal467
Updated view:
@Pranshu1902
the new button seem to be really big comparatively
@nihal467 which button? The Record
button?
@Pranshu1902 upload button and browser button, can you check the size of the buttons with the existing staging !
@nihal467
How's this?
@Pranshu1902, I think reducing the icon size might help, and I also think the color is off
@khavinshankar
updated view:
@Pranshu1902
the icons are having multiple alignment and compare it with existing staging too, the size, and alignments too, in normal and responsive view
@nihal467
Updated view:
Desktop view:
@Pranshu1902
when you upload the file. the name is showing twice. This PR is been showing new issues whenever a existing issues are been resolved, So, do a QA check before you mark it as " need testing " .