care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Revamped Upload files buttons

Open Pranshu1902 opened this issue 2 years ago • 32 comments

Fixes #3418 http://localhost:4000/sample/f01568f0-3b58-418a-96fc-89d228073462

Made buttons full width for mobile view image

Pranshu1902 avatar Aug 17 '22 05:08 Pranshu1902

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit b22b7658986cf6c32442006aef27fb7be9441892
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/635987fe8ba9090009ca26f7
Deploy Preview https://deploy-preview-3419--care-egov-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 17 '22 05:08 netlify[bot]

Updated Browse button view: image

Pranshu1902 avatar Aug 20 '22 05:08 Pranshu1902

Deploy Preview for care-net failed.

Name Link
Latest commit d0f8561a29713d8d302addeb4aaa63c2846e183e
Latest deploy log https://app.netlify.com/sites/care-net/deploys/63006ec8a161510009643d18

netlify[bot] avatar Aug 20 '22 05:08 netlify[bot]

@Pranshu1902 is it good for testing

nihal467 avatar Aug 23 '22 17:08 nihal467

@Pranshu1902 is it good for testing

Yes

Pranshu1902 avatar Aug 23 '22 17:08 Pranshu1902

image

@Pranshu1902 test failed, check the button alignment in normal view

nihal467 avatar Aug 24 '22 17:08 nihal467

@nihal467 Updated view: image

Pranshu1902 avatar Aug 24 '22 18:08 Pranshu1902

@Pranshu1902 image

in responsive view, the buttons are not having gap in between them

nihal467 avatar Aug 29 '22 16:08 nihal467

@nihal467 Updated view: image

Pranshu1902 avatar Aug 30 '22 14:08 Pranshu1902

test approved

nihal467 avatar Aug 30 '22 18:08 nihal467

@nihal can you please retest this one

khavinshankar avatar Sep 01 '22 08:09 khavinshankar

@Pranshu1902 LGTM, but merge the latest development and check the cypress test

nihal467 avatar Sep 05 '22 21:09 nihal467

@nihal467 merged develop branch

Pranshu1902 avatar Sep 06 '22 07:09 Pranshu1902

@Pranshu1902 test approved, but the cypress is failing, check it

nihal467 avatar Sep 14 '22 08:09 nihal467

@nihal467 Staging BE can't handle the speed of cypress that's why it is failing

Pranshu1902 avatar Sep 16 '22 05:09 Pranshu1902

@developedBySJ can you please re-review this pr

khavinshankar avatar Sep 21 '22 15:09 khavinshankar

@khavinshankar updated view: image

Pranshu1902 avatar Sep 28 '22 09:09 Pranshu1902

:wave: Hi, @Pranshu1902, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Oct 02 '22 04:10 github-actions[bot]

Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

stale[bot] avatar Oct 09 '22 08:10 stale[bot]

@Pranshu1902 image image

  • [ ] the buttons are off aligned in normal view and mobile view
  • [ ] the buttons are feeling over sized, look into it

nihal467 avatar Oct 11 '22 11:10 nihal467

@nihal467 Updated view: image

image

Pranshu1902 avatar Oct 11 '22 12:10 Pranshu1902

@Pranshu1902 image image

the new button seem to be really big comparatively

nihal467 avatar Oct 12 '22 06:10 nihal467

@nihal467 which button? The Record button?

Pranshu1902 avatar Oct 12 '22 06:10 Pranshu1902

@Pranshu1902 upload button and browser button, can you check the size of the buttons with the existing staging !

nihal467 avatar Oct 12 '22 06:10 nihal467

@nihal467 How's this? image

Pranshu1902 avatar Oct 12 '22 06:10 Pranshu1902

@Pranshu1902, I think reducing the icon size might help, and I also think the color is off

khavinshankar avatar Oct 12 '22 07:10 khavinshankar

@khavinshankar updated view: image

Pranshu1902 avatar Oct 14 '22 14:10 Pranshu1902

@Pranshu1902 image

the icons are having multiple alignment and compare it with existing staging too, the size, and alignments too, in normal and responsive view

nihal467 avatar Oct 17 '22 14:10 nihal467

@nihal467 Updated view: image

Desktop view: image

Pranshu1902 avatar Oct 19 '22 13:10 Pranshu1902

@Pranshu1902

image

when you upload the file. the name is showing twice. This PR is been showing new issues whenever a existing issues are been resolved, So, do a QA check before you mark it as " need testing " .

nihal467 avatar Oct 20 '22 06:10 nihal467